From nobody Sat Sep 6 08:23:53 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cJmT74RMgz66FYN; Sat, 06 Sep 2025 08:23:55 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cJmT72C63z419n; Sat, 06 Sep 2025 08:23:55 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757147035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PS3VjRLFPm598vfn7I2MTN5rjr2uXrTmOIER/QxFHzs=; b=eFmNCMhUJtRt2J/BTjSzo8oJjmwz6U9mPYhut7g6y4hjMTa2BEE2AOjkJ+/sP7XIyBsxcx U9eHFWMxU/vX98I3/Sn8INr0mUpmDjHHDA+zLkXBeenivp8WVDuKZngT5e3bor+cEo02/V nVz3Ih1LROIQvFG0BynPL+uNrS6h0qUC2ahXSfAPAX9ZhitQMGHupAFJrx4Fxeaw3zMe6a /8I4MQy3OzSrE/DFKgqn6oYs9bM5lN1zyPorvz95XOGBU78x+seXipUPsoj4H/uk5U3s+w yDcE7PEWjkgxsA7gZIKP5oR/lUEr6oKKaVFZBXaPLu9mG6m+qKpTRPn0SSMMHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757147035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PS3VjRLFPm598vfn7I2MTN5rjr2uXrTmOIER/QxFHzs=; b=yMjWjx2UJ1OWja2315vbKbeIU/hDyW/42wYKiH6G5ddOhOgwyHupEnjMglJdh2a8MamVD0 P24nLZTVJhuzNfqC+yhVqlFKhsOmaKI9nUXUmOK/fbqB6dWJRZ/GacgY16OUuFwaSNgicV Gd4h8Ew9jQNWvoFC/y4+4oRgXWSs7is74JF1EO+HP0Cm8MjZjvhh1deTRC5tyubX9Ujc/X K9VKYTnjoPhFMZ1+sZESoaztNayDe+CRKh/c2kCY4twCLG3VuTCxf3jaT8HaTAKNN9j/pe k3ulrSZkVSe00Pd7pZrVDp9CGoCjjm6Ko/RG61d8tVbfjJBqnijWqcts5oyziw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757147035; a=rsa-sha256; cv=none; b=pSr3IAyFE+r2gFvNlG81ONRrqerKEqlJG/18dshvuqtwes8MQJnCsm7+P6dZGgJXl6UMrT KipiZxGca0HynScFQ94QEp8fhJxhvordV0husEUVM/onesGha8230XYW+5MM/+KdeKNU0R QEpO+RAjP29J2c7iSaAFYHu7WldGS6dJxy1H8j4adZkD3fQNz0Wp1Su1+P5XrUZarQGmtJ PVecXp80QwFVtDovZm0H3FbQlABgeLgGKQI0a55pcPs3TbZZ1bEhYN0ow2OJ9F1FYnDAh/ eilALoZE5Ri3rZbohg/Woj8HeIbZNwqjzlvzYBYjhi75CrRYwVuJP+Yq6YBytQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:c08a:2eed:fd3d:59e7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cJmT64qHfz9hK; Sat, 06 Sep 2025 08:23:54 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: 1c23d8f9f398 - main - vtnet: improve checksum offloading From: Michael Tuexen In-Reply-To: <23rq9r12-75nn-sqs8-06o7-p785s2q915o3@yvfgf.mnoonqbm.arg> Date: Sat, 6 Sep 2025 10:23:53 +0200 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <8A4EFC13-ABA3-471B-9726-5940E2B88DED@FreeBSD.org> References: <202509041126.584BQBBt067763@gitrepo.freebsd.org> <23rq9r12-75nn-sqs8-06o7-p785s2q915o3@yvfgf.mnoonqbm.arg> To: "Bjoern A. Zeeb" X-Mailer: Apple Mail (2.3826.700.81) > On 5. Sep 2025, at 23:09, Bjoern A. Zeeb = wrote: >=20 > On Thu, 4 Sep 2025, Michael Tuexen wrote: >=20 >> The branch main has been updated by tuexen: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D1c23d8f9f39870951c1d0dfbb112fc4e= 53237737 >>=20 >> commit 1c23d8f9f39870951c1d0dfbb112fc4e53237737 >> Author: Michael Tuexen >> AuthorDate: 2025-09-04 11:16:46 +0000 >> Commit: Michael Tuexen >> CommitDate: 2025-09-04 11:16:46 +0000 >>=20 >> vtnet: improve checksum offloading >>=20 >> When transmitting a packet over the vtnet interface, map the >> csum flags CSUM_DATA_VALID | CSUM_PSEUDO_HDR to the virtio >> flag VIRTIO_NET_HDR_F_DATA_VALID. >> When receiving a packet over the virtio network channel, translate >> the virtio flag VIRTIO_NET_HDR_F_NEEDS_CSUM not to CSUM_DATA_VALID = | >> CSUM_PSEUDO_HDR, but to CSUM_TCP, CSUM_TCP_IPV6, CSUM_UDP, or >> CSUM_UDP_IPV6. >> The second change fixes a series of issue related to checksum >> offloading for if_vtnet. >> While there, improve the stats counters to allow a detailed view >> on what is going on in relation to checksum offloading. >>=20 >> PR: 165059 >> Reviewed by: tuexen, manpages >> MFC after: 1 week >> Differential Revision: https://reviews.freebsd.org/D51686 >=20 >=20 > This fails to build a LINT-NOIP now. Makes me wonder what good vtnet = is > in first place w/o INET and w/o INET6? >=20 > 33 | ^~~~~~~~~~~ > 34 1 warning generated. > 35 = /tank/users/bz/git/FreeBSD/freebsd-src/sys/dev/virtio/network/if_vtnet.c:1= 825:9: error: call to undeclared function 'in_cksum_skip'; ISO C99 and = later do not support implicit function declarations = [-Werror,-Wimplicit-function-declaration] > 36 1825 | csum =3D in_cksum_skip(m, m->m_pkthdr.len, = hdr->csum_start); > 37 | ^ > 38 = /tank/users/bz/git/FreeBSD/freebsd-src/sys/dev/virtio/network/if_vtnet.c:1= 849:6: error: variable 'hoff' set but not used = [-Werror,-Wunused-but-set-variable] > 39 1849 | int hoff, protocol; > 40 | ^ > 41 2 errors generated. > 42 --- if_vtnet.o --- > 43 *** [if_vtnet.o] Error code 1 OK, that is fixed in = https://cgit.FreeBSD.org/src/commit/?id=3D7c448f5aab8be6977d0860e608e7d497= b495d28c = Thanks again for reporting and I am sorry for breaking the NOIP (again). BTW: Is there a reason we don't have the NOINET, NOINET6, and NOIP = kernel configs for arm64? Best regards Michael >=20 >=20 >> --- >> share/man/man4/vtnet.4 | 28 +++-- >> sys/dev/virtio/network/if_vtnet.c | 220 = ++++++++++++++++++----------------- >> sys/dev/virtio/network/if_vtnetvar.h | 2 +- >> 3 files changed, 132 insertions(+), 118 deletions(-) >>=20 >> diff --git a/share/man/man4/vtnet.4 b/share/man/man4/vtnet.4