From nobody Sat Aug 1 08:56:04 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBxcN2BGKz6nHPc for ; Sat, 01 Aug 2026 08:56:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBxcN1PFmz3qSQ for ; Sat, 01 Aug 2026 08:56:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785574564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vvzbvrgqnO9XaqmjkrsebOwWnGko5m0iDYYj/n5MbS4=; b=A+lsewT+pAZV4CGJqb69/0SoJMh6q8Bsi6wAv5nTC1GEfKGOlH24cQsQ8ZoR7Q7qS+2spx Nt7XUs/0hIkiWSWDHOYaIaib3UOOs0vn6WDCoXMBIy27daurdUEmJpMPhI+/FrIgfJpeOf 0RXnXmc+15a2nlsjYNw78vi4CkzyvL9962s2t4n48NFAjxZIj+sCNHvse3ksS+vun6FQtN WAWdTuQ+8V0/rrLp0a6Wwqiu+NLBwhFwP54srbVbq73NMfROJN4vOyObSfmcpm29Ax1ee6 tFL966kQAMBpc2pY7SQSDH499C21OqGbTBjpxuu8D15O/SdDQf7laC5Z+ryyeg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785574564; a=rsa-sha256; cv=none; b=FYXJ6THjd2EGgnnYFlJVpnaC+lwDjDkvP/8saHeNUgG9Y1ws0MtOu6CuxLvJtLyP11Zp+H O6vp9TKmlTjWjN1VWF8MP9DJ/MI+Y5jb5J/aQe7VwSQ6kWisZKdyCzUlTE5szjgb1RYEjx BEMiD76bFaVgIFP/f8GE3F6cL45ElZ3RCcw9LV43nYhnq/OhFB7WMVOtn2QbKTYzV5Nkrt c2dj60ugx9u7Qph6mK5SHbvwGvaYRGjjvNbba6LzQ3oiFAurHNBq3uqb3CPnLKnSeT54ZO WFeyrRSr0TATqeGG9gymvuEn5NUxAhP5JXcIvYTzH7ZrZys74pBk1Kc0IdB7yA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785574564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vvzbvrgqnO9XaqmjkrsebOwWnGko5m0iDYYj/n5MbS4=; b=pluAlEsJAWJGUl3BsxbJOHhHo0s0QmCpdlGI098EviaxpnJUsBhUPA8ML4nZj9B2Vb3lc8 Wl6AiuLHuPNLtfpn06CO8P9MGN08W9hHaaMqeUk070Tx/d+TLc7llAjU+GlRegsTgLsldM 14pbymAn38ELQXDe1YKzrA7tohOBtF43gvMYgrXnaLn0RCqSOGyPDMvJAV5z7cJHYrH1ru nmHSevW5i9FtyHU8+dPi38JJwSOladNeDqRveNYFfEpZ1l3FDLBR9RmoGvRY41rUGYe70H CQZUO+F6vz4u2+JZr2LBv5D9c/alpatMk0YKOTYhkakfYs/gc98V3Bch8Y34FQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBxcN0BSNzf6k for ; Sat, 01 Aug 2026 08:56:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2742a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 01 Aug 2026 08:56:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: d2309d9d6dc6 - main - ixl: enforce the assigned VF MAC address List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d2309d9d6dc6d5a9141314652d6c96ab46a9a62c Auto-Submitted: auto-generated Date: Sat, 01 Aug 2026 08:56:04 +0000 Message-Id: <6a6db4a4.2742a.5334a318@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=d2309d9d6dc6d5a9141314652d6c96ab46a9a62c commit d2309d9d6dc6d5a9141314652d6c96ab46a9a62c Author: Kevin Bowling AuthorDate: 2026-08-01 02:38:54 +0000 Commit: Kevin Bowling CommitDate: 2026-08-01 08:55:50 +0000 ixl: enforce the assigned VF MAC address When allow-set-mac is disabled, the MAC filter validation condition rejects the assigned VF unicast address while allowing any different unicast address. The equality test was accidentally inverted when this code moved to the boolean address helper. Accept multicast and the assigned unicast address, and reject other unicast addresses as intended. Fixes: 7d4dceec1030 ("ixl(4): Fix VLAN HW filtering") MFC after: 3 days --- sys/dev/ixl/ixl_pf_iov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/ixl/ixl_pf_iov.c b/sys/dev/ixl/ixl_pf_iov.c index ca2759557066..1e475e4767cc 100644 --- a/sys/dev/ixl/ixl_pf_iov.c +++ b/sys/dev/ixl/ixl_pf_iov.c @@ -1022,7 +1022,7 @@ ixl_vf_mac_valid(struct ixl_vf *vf, const uint8_t *addr) * is not its assigned MAC. */ if (!(vf->vf_flags & VF_FLAG_SET_MAC_CAP) && - !(ETHER_IS_MULTICAST(addr) || !ixl_ether_is_equal(addr, vf->mac))) + !(ETHER_IS_MULTICAST(addr) || ixl_ether_is_equal(addr, vf->mac))) return (EPERM); return (0); @@ -1824,4 +1824,3 @@ out: return (error); } -