From owner-freebsd-virtualization@freebsd.org Tue Apr 23 12:10:01 2019 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E6D01598A0F for ; Tue, 23 Apr 2019 12:10:01 +0000 (UTC) (envelope-from paul@redbarn.org) Received: from family.redbarn.org (family.redbarn.org [IPv6:2001:559:8000:cd::5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 603186EF03 for ; Tue, 23 Apr 2019 12:10:00 +0000 (UTC) (envelope-from paul@redbarn.org) Received: from [172.16.74.22] (unknown [50.235.236.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by family.redbarn.org (Postfix) with ESMTPSA id 98A17892C6 for ; Tue, 23 Apr 2019 12:09:57 +0000 (UTC) Subject: Re: [vm-bhyve] Windows 2012 and 2016 servers guests would not stop To: freebsd-virtualization@freebsd.org References: <20190421154616.GA59283@admin.sibptus.ru> <201904211708.x3LH8DiK028282@gndrsh.dnsmgr.net> <20190423024301.GA940@admin.sibptus.ru> <20190423041358.GA2992@admin.sibptus.ru> From: Paul Vixie Message-ID: <212b6254-1e27-8311-885b-601f8b1d710c@redbarn.org> Date: Tue, 23 Apr 2019 05:09:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 PostboxApp/6.1.14 MIME-Version: 1.0 In-Reply-To: <20190423041358.GA2992@admin.sibptus.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 12:10:01 -0000 Victor Sudakov wrote on 2019-04-22 21:13: ... >>>> sleep 1 ... >> i think this is worse than brutal, it's wrong. consider freebsd's own >> work flow when trying to comply with the first soft shutdown it got: >> >> https://github.com/freebsd/freebsd/blob/master/sbin/reboot/reboot.c#L220 >> >> this has bitten me more than once, because using "pageins" as a proxy >> for "my server processes are busy trying to synchronize their user mode >> state" is inaccurate. i think _any_ continuing I/O should be reason to >> wait the full 60 seconds. > > Would it be beneficial to just hack /usr/local/lib/vm-bhyve/vm-* ? no, i really think the hypervisor should add i/o monitoring, so that if the soft shutdown signal is sent, the client kernel is allowed to keep running until either a really long timeout (60 seconds or more), but if it becomes quiet, then the hypervisor can exit sooner. >> i agree with this. > > Will you please support the bug report: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237479 done. -- P Vixie