From owner-freebsd-fs@FreeBSD.ORG Sat Mar 26 14:12:06 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 779C1106564A for ; Sat, 26 Mar 2011 14:12:06 +0000 (UTC) (envelope-from giffunip@tutopia.com) Received: from nm8.bullet.mail.sp2.yahoo.com (nm8.bullet.mail.sp2.yahoo.com [98.139.91.78]) by mx1.freebsd.org (Postfix) with SMTP id 529538FC0C for ; Sat, 26 Mar 2011 14:12:06 +0000 (UTC) Received: from [98.139.91.63] by nm8.bullet.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 14:12:05 -0000 Received: from [98.139.91.33] by tm3.bullet.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 14:12:05 -0000 Received: from [127.0.0.1] by omp1033.mail.sp2.yahoo.com with NNFMP; 26 Mar 2011 14:12:05 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 935660.66135.bm@omp1033.mail.sp2.yahoo.com Received: (qmail 68680 invoked by uid 60001); 26 Mar 2011 14:12:05 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1301148725; bh=U72zgvIzVdTDwbm0D/hBUxnFfJb02PMO6ZdQg8zC4kY=; h=Message-ID:X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=jvk93OPMW+5yzrMN0lLn9d3vv8/tRcVlh7SefDYFm4m34n2BRuckltn1ZnVlEMZqWd+fbXiGZWNVavGSL2lWYLGIfYwlfYVcofaCTOF3pHx3vv35nIlQFzWgiBj/uPlMksvdN59wEfVicyZJ4ICb1nkbsCPRNJhH2eJR+GjKZm8= Message-ID: <553011.63188.qm@web113509.mail.gq1.yahoo.com> X-YMail-OSG: rxgquwgVM1nnyBt_HUxuKUZahUhEf.y30yL3Atakx5akS0Q jPXfQnGZP_ivbcCfPH1sKxErjjc74J4CaPqWGpj7Hh5qSorU.Bypee_QVM1r qYT57k4rybBFnJ1KZSq466F0L7Ii8F1gWSRb1aJjAzd1xquE9SqOBVlJRg8O a6y_74LZLFVEHisg0MJc412v_SRgSPvYQzqC6fJ8VZBaxscMfQatRe13Bxlx siXFmkp17n5Olgmxr1QiuIsOxmEmnvF7TWNh62BuDxpLIXx.FwQz_hKQBe8y 0RX1A6TEeZOCO230OrbOgOJFcCSRrlZ3cJL8W1_xKz4.nPDjVl8dQ.u71M94 DFsDfw9cK0po7g1huG7GFZucsnNbSR_0YRmDsbNvrT3H_vZGCghoIx0j8jhb qQ6M1ME4w5bjp Received: from [200.118.159.55] by web113509.mail.gq1.yahoo.com via HTTP; Sat, 26 Mar 2011 07:12:05 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/12.0.2 YahooMailWebService/0.8.109.295617 Date: Sat, 26 Mar 2011 07:12:05 -0700 (PDT) From: "Pedro F. Giffuni" To: Kostik Belousov In-Reply-To: <20110326120421.GX78089@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mikolaj Golub , freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: giffunip@tutopia.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2011 14:12:06 -0000 --- On Sat, 3/26/11, Kostik Belousov wrote: ... > Ok, after rereading the code, I do not believe that we need > the change. The doscheckpath() does vput() on tdvp, and tvp > is vput'ed right before line 1083, so jumping to the label > `bad' instead of `out' will only result in the lock > assertion being fired. > > Also, the msdosfs mount correctly unmounts after the > attempt to perform a rename that doscheckpath() banned. > This is additional evidence supporting my point. > > The question is, why did you decided that the fix is needed > for FreeBSD ? > Defensive programming. On NetBSD this apparently started causing problems for unknown reasons, and doing the change doesn't have any ill effect on FreeBSD. I am OK, if you want to close the PR though, and thanks for doing the complete research. Pedro.