Date: Wed, 5 Aug 2009 13:36:47 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Dimitry Andric <dimitry@andric.com> Cc: freebsd-hackers@freebsd.org, Mel Flynn <mel.flynn+fbsd.hackers@mailing.thruhere.net> Subject: Re: Spot the error Message-ID: <20090805203647.GX47463@elvis.mu.org> In-Reply-To: <4A798E1B.9010109@andric.com> References: <200908041245.35926.mel.flynn%2Bfbsd.hackers@mailing.thruhere.net> <4A78AB7C.3040406@andric.com> <200908041615.49128.mel.flynn%2Bfbsd.hackers@mailing.thruhere.net> <4A798E1B.9010109@andric.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dimitry Andric <dimitry@andric.com> [090805 06:51] wrote: > On 2009-08-05 02:15, Mel Flynn wrote: > > I would expect "Unable to load fs: " + ENOENT. I was asking if this was > > fixable, cause it looked like the code has been abstracted to the point that > > specific errors were hard, but maybe I missed something. > > It does not seem easily fixable. The problem is that the mount command > simply prints out the error of the system call, and doesn't have any > idea which of the (many) parameters was wrong. > > You could change the returned error in this particular case to ENOENT, > of course, but that might be considered even more confusing. Like, > "What do you mean, that SCSI disk doesn't exist? It's right there in > /dev!" > > One could also argue for EINVAL, but there's the bikeshed again... :) mount 9 could be augmented to preflight/postflight the vfs type name through the provide a better error. -- - Alfred Perlstein .- AMA, VMOA #5191, 03 vmax, 92 gs500, 85 ch250 .- FreeBSD committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090805203647.GX47463>