From owner-cvs-src@FreeBSD.ORG Mon Aug 2 07:02:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 68AD116A4CF; Mon, 2 Aug 2004 07:02:16 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id D523943D6D; Mon, 2 Aug 2004 07:02:15 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id E2A27ACAF4; Mon, 2 Aug 2004 09:02:14 +0200 (CEST) Date: Mon, 2 Aug 2004 09:02:14 +0200 From: Pawel Jakub Dawidek To: Nate Lawson Message-ID: <20040802070214.GN39839@darkness.comp.waw.pl> References: <20040731151315.99E5916A539@hub.freebsd.org> <410D84DA.3040701@cryptography.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qi3SIpffvxS/TM8d" Content-Disposition: inline In-Reply-To: <410D84DA.3040701@cryptography.com> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/dd args.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2004 07:02:16 -0000 --qi3SIpffvxS/TM8d Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 01, 2004 at 05:03:38PM -0700, Nate Lawson wrote: +> >@@ -361,18 +361,23 @@ +> >=20 +> > mult =3D 0; +> > switch (*expr) { +> >+ case 'B': +> > case 'b': +> > mult =3D 512; +> > break; +>=20 +> Instead of doubling the case statements, it's simpler to do +> "switch (tolower(*expr))" or toupper(). Sure, but I leave it to maintainer to decide. I personally prefer to see exactly what's going on, and I also wasn't sure while committing if we really want capital 'W'. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --qi3SIpffvxS/TM8d Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBDeb2ForvXbEpPzQRAm53AKDHq3Do6Ghe1yVR1ucoq3/A7fKMHwCg83J0 kYCjZZMvXpxvZQpLRQ3lebA= =lreb -----END PGP SIGNATURE----- --qi3SIpffvxS/TM8d--