Date: Mon, 2 Aug 2004 09:02:14 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Nate Lawson <nate@cryptography.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/dd args.c Message-ID: <20040802070214.GN39839@darkness.comp.waw.pl> In-Reply-To: <410D84DA.3040701@cryptography.com> References: <20040731151315.99E5916A539@hub.freebsd.org> <410D84DA.3040701@cryptography.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--qi3SIpffvxS/TM8d
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Aug 01, 2004 at 05:03:38PM -0700, Nate Lawson wrote:
+> >@@ -361,18 +361,23 @@
+> >=20
+> > mult =3D 0;
+> > switch (*expr) {
+> >+ case 'B':
+> > case 'b':
+> > mult =3D 512;
+> > break;
+>=20
+> Instead of doubling the case statements, it's simpler to do
+> "switch (tolower(*expr))" or toupper().
Sure, but I leave it to maintainer to decide.
I personally prefer to see exactly what's going on, and I also wasn't
sure while committing if we really want capital 'W'.
--=20
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
--qi3SIpffvxS/TM8d
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFBDeb2ForvXbEpPzQRAm53AKDHq3Do6Ghe1yVR1ucoq3/A7fKMHwCg83J0
kYCjZZMvXpxvZQpLRQ3lebA=
=lreb
-----END PGP SIGNATURE-----
--qi3SIpffvxS/TM8d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040802070214.GN39839>