From owner-svn-src-head@freebsd.org  Sun Jun  5 20:07:31 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46046B6BFEE
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sun,  5 Jun 2016 20:07:31 +0000 (UTC)
 (envelope-from mailing-machine@vniz.net)
Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com
 [209.85.215.53])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CE9861673
 for <svn-src-head@freebsd.org>; Sun,  5 Jun 2016 20:07:30 +0000 (UTC)
 (envelope-from mailing-machine@vniz.net)
Received: by mail-lf0-f53.google.com with SMTP id s64so83100042lfe.0
 for <svn-src-head@freebsd.org>; Sun, 05 Jun 2016 13:07:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:subject:to:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-transfer-encoding;
 bh=j2JCegc/W9+2asuZGJf2/cbBUrncyQmr8XRw7hAES9k=;
 b=dR8NX68WW+V3uumlCYlB9UF0NBee0AlSQaJHvdJp3+WqtmM+NiDRUPbFxlKegbt9PD
 7z2U3IcbUFXPsBtFXB1TrrXjXcOwHSKsmr/8auXa0JbsL2AmKOujA37zaWS1Sw+TdQfm
 IXwMthtGvujtkar7F3qwmR+JDy5koXQARw6cYEbcm00VNDqIxjx+2wgZMDOj9VEfFsfv
 G5nX9uaDr+OmvqEFPFcV07M3v95OUX9NitXYVsKwC1LAO2g+cXEbkYTdSlpn2IbBMvvR
 kkyyDlBddVW0SNLYi4DHRM56bgDxapolgTZiaqONgPf7ygFsfcyB2iGL78tCZD+E30l/
 yeig==
X-Gm-Message-State: ALyK8tL3Jbc3rXbYbjxXwN0ltdym7rFuXM+2KprEKP+g9DVX5XTs/tMLDLpDcvqGn0nJtw==
X-Received: by 10.25.29.85 with SMTP id d82mr436857lfd.93.1465157248525;
 Sun, 05 Jun 2016 13:07:28 -0700 (PDT)
Received: from [192.168.1.2] ([89.169.173.68])
 by smtp.gmail.com with ESMTPSA id h67sm1360239lji.39.2016.06.05.13.07.27
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sun, 05 Jun 2016 13:07:27 -0700 (PDT)
Subject: Re: svn commit: r301461 - in head/lib/libc: gen locale regex
To: "Pedro F. Giffuni" <pfg@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201606051912.u55JCqdR036458@repo.freebsd.org>
From: Andrey Chernov <ache@freebsd.org>
Message-ID: <8513a0d8-01b4-45bb-4e22-0829683652af@freebsd.org>
Date: Sun, 5 Jun 2016 23:07:26 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <201606051912.u55JCqdR036458@repo.freebsd.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Jun 2016 20:07:31 -0000

On 05.06.2016 22:12, Pedro F. Giffuni wrote:
>   When collation support was brought in, the second and third
>   arguments in __collate_range_cmp() were changed from int to
>   wchar_t, breaking the ABI. Change them to a "char" type which
>   makes more sense and keeps the ABI compatible.

Not only that breaks ABI, but changing strcoll_l() to wcscoll_l() in the
__collate_range_cmp() too (now fixed), while this function is visible
outside of libc.