From nobody Tue Jan 20 04:09:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dwDNg46ZBz6Nw8w for ; Tue, 20 Jan 2026 04:09:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dwDNg21CQz3VPj for ; Tue, 20 Jan 2026 04:09:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768882163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qIFnMtVgkNX6UnZjzTntfa1nysiVJhnFFsvDRJFEM94=; b=Ht4l6uZ/dah4eNvi4rzrlxOmmxhAkg1WDsXb0JvTT8/Xf2SkQQHDyLm+ItA5+G0ZQmL6aR zgzd878bhfMg6bW57WOZHjD1XH6mn1N6hcaKVBxTwtiTDQWraQ4lCpXWT7F2HAUB8dCEBl zc/7rff7Sh7rkLePGTdKY2BKtY19ju0IokTSGkOff1Io0zOac8fTq7Rb7C/RW9Lq1b2OuW ysKfcXGWEjuu8YGQxgejeACIvAmRmGT9JLqhck4YHWs0V9aG0HSYk0nYtiYr05nvrs+4Wj k5yncSbGjTdFSBB9b7E73Tc+y3LIsxrmn3JgIyxUyqzJHVAbrRNH9raQBg/1MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768882163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qIFnMtVgkNX6UnZjzTntfa1nysiVJhnFFsvDRJFEM94=; b=PnbNEYDeqnHFWwvNfZCHFTo73lbKo4chk/O2O4dmR2w1fBFz+N0Cy6sHP4IpNXYMYQ0cHp JU5GitZGKnFBHgEYHT0+l4tdmxaj/bNsXf2Dhz8vu3sY93yfqXm5RIunh+ZaG4uDwhj38n ytQ7d0Y81092HNXwVcYS8KqJ3cC/5XaVAyocLd5JawW4w9If0XpNahgdRBbqFmlSgnvCAy cn2YmxJ2HAdzENZV69AjGVQGAUR9cU8ACXlnURPV+G9qzevHwNYPid4UoFBQ+Czf3boPGh 7zjIai1GwX9JwB4F04AsNj7vyofbjvLsJ31QZU2ZZyylP+pTKxTNK5yzJoVcwQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768882163; a=rsa-sha256; cv=none; b=SVDx3mbddfkL5sOk/213ttNrp4IyzJGgkNGg7yo2fQWot8Fn8qb15In3LiPtZc/HimSNhH kfywxaC6JKzHl8L6hldJQ8guT/JuxZu/45NBJwqPJcrDh38GC5B6DJmnwZ6CHSUtdpoQ2R m+BEW5zqXT0Hd2svrWPpqTLMrqZmtWK/GGWF2LY2jli0QYisHwF4LbPfKNdbhqG4P4JWk7 niZ+E5W6sjELtCla3+V0DlGuUeUV/voMQRUKY8vzi+EW8HSwbI+ARoJYnUTzgvtiQMLeWa ktczRpeE9nI5zvTiCDrmQ2VTzJkCtGmSQw6i6yoU2yKQcBD8Jzxxvp/yIIRejg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dwDNg1Zwcz11xH for ; Tue, 20 Jan 2026 04:09:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27bae by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 20 Jan 2026 04:09:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kyle Evans Subject: git: 5b2a74210408 - stable/15 - makedev(9): drop an additional note about cdevpriv dtors List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 5b2a742104082dbeb2a9c4433117b16dcbeaa62d Auto-Submitted: auto-generated Date: Tue, 20 Jan 2026 04:09:23 +0000 Message-Id: <696efff3.27bae.488b5785@gitrepo.freebsd.org> The branch stable/15 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=5b2a742104082dbeb2a9c4433117b16dcbeaa62d commit 5b2a742104082dbeb2a9c4433117b16dcbeaa62d Author: Kyle Evans AuthorDate: 2025-11-05 00:28:02 +0000 Commit: Kyle Evans CommitDate: 2026-01-20 04:04:33 +0000 makedev(9): drop an additional note about cdevpriv dtors These were previously somewhat safe to call destroy_dev(9), but will now also cause a deadlock in the same fashion that d_close doing so would previously. Amend the note to point it out, in case it's useful for someone. Reviewed by: imp, kib, markj (cherry picked from commit 90314c04f10f583c37c59ec51fd628e3deaf3622) --- share/man/man9/make_dev.9 | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/share/man/man9/make_dev.9 b/share/man/man9/make_dev.9 index de56f350faa5..9f2c36fb39a4 100644 --- a/share/man/man9/make_dev.9 +++ b/share/man/man9/make_dev.9 @@ -25,7 +25,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd January 19, 2025 +.Dd November 4, 2025 .Dt MAKE_DEV 9 .Os .Sh NAME @@ -387,14 +387,18 @@ function is the same as: destroy_dev_sched_cb(cdev, NULL, NULL); .Ed .Pp -The +Neither the .Fn d_close -driver method cannot call +driver method, nor a +.Xr devfs_cdevpriv 9 +.Fa dtr +method can .Fn destroy_dev directly. Doing so causes deadlock when .Fn destroy_dev -waits for all threads to leave the driver methods. +waits for all threads to leave the driver methods and finish executing any +per-open destructors. Also, because .Fn destroy_dev sleeps, no non-sleepable locks may be held over the call.