From owner-freebsd-stable@FreeBSD.ORG Mon Oct 22 18:41:03 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A191ABDC; Mon, 22 Oct 2012 18:41:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 759128FC1A; Mon, 22 Oct 2012 18:41:03 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C95E3B94F; Mon, 22 Oct 2012 14:41:02 -0400 (EDT) From: John Baldwin To: Andrey Chernov Subject: Re: ${CTFCONVERT_CMD} expands to empty string Date: Mon, 22 Oct 2012 13:47:04 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p20; KDE/4.5.5; amd64; ; ) References: <5081F92F.8040004@freebsd.org> <50857831.1070603@freebsd.org> <50857C01.8050500@freebsd.org> In-Reply-To: <50857C01.8050500@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable Message-Id: <201210221347.04727.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 22 Oct 2012 14:41:02 -0400 (EDT) Cc: freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 18:41:03 -0000 On Monday, October 22, 2012 1:01:53 pm Andrey Chernov wrote: > All that happens because this commit is not merged into stable-9. > Do you plan to mere it by yourself? >=20 > r228157 | fjoe | 2011-11-30 22:07:38 +0400 (=D3=D2, 30 =CE=CF=D1 2011) | = 10 lines >=20 > - Fix segmentation fault when running "+command" when run with -jX -n due > to Compat_RunCommand() being called with `cmd' that is not on the node- >commands > list > - Make ellipsis ("..." command) handling consistent: check for "..." comm= and > in job make after variables expansion to match compat make behavior > - Fix empty command handling (after variables expansion and @+- modifiers > are processed): now empty commands are ignored in compat make and are not > printed in job make case > - Bump MAKE_VERSION to 5-2011-11-30-0 As soon as I can reproduce something that tests it, sure (I want to have a= =20 test case I can reproduce so that I can also check for 8). Your test Makefile does break on 8 and 9, want to do some more tests. > On 22.10.2012 20:45, Andrey Chernov wrote: > > And simple test case proving that make v9201206140 dislike empty comman= ds. > > Makefile: > > ------------------------------------------------ > > CTFCONVERT_CMD=3D > > all: > > echo ${MAKE_VERSION} > > ${CTFCONVERT_CMD} > > echo b > > ------------------------------------------------ > >> make > > echo 9201206140 > > 9201206140 > > ${CTFCONVERT_CMD} expands to empty string > > echo b > > b =2D-=20 John Baldwin