From owner-svn-ports-head@freebsd.org  Thu Jun 25 11:24:25 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 630DB98CD44;
 Thu, 25 Jun 2015 11:24:25 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216])
 by mx1.freebsd.org (Postfix) with ESMTP id 2C00F10D5;
 Thu, 25 Jun 2015 11:24:24 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from hive.panopticon (unknown [78.153.152.119])
 by vps.amdmi3.ru (Postfix) with ESMTPS id 7C7D3B0656;
 Thu, 25 Jun 2015 14:24:21 +0300 (MSK)
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id D36C3CC;
 Thu, 25 Jun 2015 14:22:44 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id 1BC58124895; Thu, 25 Jun 2015 14:21:17 +0300 (MSK)
Date: Thu, 25 Jun 2015 14:21:17 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: marino@freebsd.org
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r390555 - head/comms/gnuradio
Message-ID: <20150625112117.GC93665@hades.panopticon>
References: <201506251046.t5PAkhLC097964@svn.freebsd.org>
 <558BE206.2050700@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <558BE206.2050700@marino.st>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2015 11:24:25 -0000

* John Marino (freebsd.contact@marino.st) wrote:

> > Author: amdmi3
> > Date: Thu Jun 25 10:46:42 2015
> > New Revision: 390555
> > URL: https://svnweb.freebsd.org/changeset/ports/390555
> > 
> > Log:
> >   - Mark BROKEN on 9.x:
> >   
> >   /wrkdirs/usr/ports/comms/gnuradio/work/gnuradio-3.7.4/volk/kernels/volk/volk_8u_x4_conv_k7_r2_8u.h:191: error: incompatible type for argument 1 of '__builtin_ia32_psrlqi128'
> >   head/comms/gnuradio/Makefile
> > 
> > Modified: head/comms/gnuradio/Makefile
> > ==============================================================================
> > --- head/comms/gnuradio/Makefile	Thu Jun 25 10:40:00 2015	(r390554)
> > +++ head/comms/gnuradio/Makefile	Thu Jun 25 10:46:42 2015	(r390555)
> > @@ -35,6 +35,8 @@ LIB_DEPENDS=	libcppunit.so:${PORTSDIR}/d
> >  		libgsl.so:${PORTSDIR}/math/gsl
> >  RUN_DEPENDS:=	${BUILD_DEPENDS}
> >  
> > +BROKEN_FreeBSD_9=	does not build on FreeBSD 9.x
> > +
> 
> The "reason" is a bit redundant.
> code: > IGNORE=         is marked as broken on ${OPSYS} ${OSREL}:
> ${BROKEN_${OPSYS}_${OSREL:R}}
> 
> means fail reason string will be:
> 
> "is marked as broken FreeBSD 9.3: does not build on FreeBSD 9.x"
> 
> something like:
> BROKEN_FreeBSD_9=incompatible type for argument 1 of
> '__builtin_ia32_psrlqi128'
> 
> might be more descriptive?
> 
> This is just food for thought.  I always find the "broken on 9.x"
> messages not to add anything new.

Hm, I wasn't aware there were specialized message. I don't find pasting
compiler errors useful here, as this message is intended for end-users
and may be confusing to them. I guess I'll go with just 'does not build'
then.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru      http://amdmi3.ru