From owner-svn-src-all@freebsd.org Fri Jan 25 20:15:48 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0020014C1A79; Fri, 25 Jan 2019 20:15:47 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5B4BA70564; Fri, 25 Jan 2019 20:15:47 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0PKFjUq090039; Fri, 25 Jan 2019 12:15:45 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0PKFjeT090038; Fri, 25 Jan 2019 12:15:45 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201901252015.x0PKFjeT090038@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r343449 - in head/sbin: newfs tunefs In-Reply-To: <201901252007.x0PK7IVr092925@repo.freebsd.org> To: Kirk McKusick Date: Fri, 25 Jan 2019 12:15:45 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 5B4BA70564 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.967,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 20:15:48 -0000 > Author: mckusick > Date: Fri Jan 25 20:07:18 2019 > New Revision: 343449 > URL: https://svnweb.freebsd.org/changeset/base/343449 > > Log: > Allow tunefs to include '_' as a legal character in label names > to make it consistent with newfs. Document the legality of '_' > in label names in both tunefs(8) and newfs(8). > > PR: 235182 > Submitted by: darius@dons.net.au > Reviewed by: Conrad Meyer > MFC after: 3 days > Sponsored by: Netflix > > Modified: > head/sbin/newfs/newfs.8 > head/sbin/tunefs/tunefs.8 > head/sbin/tunefs/tunefs.c > > Modified: head/sbin/newfs/newfs.8 > ============================================================================== > --- head/sbin/newfs/newfs.8 Fri Jan 25 20:02:55 2019 (r343448) > +++ head/sbin/newfs/newfs.8 Fri Jan 25 20:07:18 2019 (r343449) > @@ -89,6 +89,7 @@ See > for details. > .It Fl L Ar volname > Add a volume label to the new file system. > +Legal characters are alphanumerics and underscores. > .It Fl N > Cause the file system parameters to be printed out > without really creating the file system. > > Modified: head/sbin/tunefs/tunefs.8 > ============================================================================== > --- head/sbin/tunefs/tunefs.8 Fri Jan 25 20:02:55 2019 (r343448) > +++ head/sbin/tunefs/tunefs.8 Fri Jan 25 20:07:18 2019 (r343449) > @@ -112,6 +112,7 @@ By default > sets it to half of the space reserved to minfree. > .It Fl L Ar volname > Add/modify an optional file system volume label. > +Legal characters are alphanumerics and underscores. > .It Fl l Cm enable | disable > Turn on/off MAC multilabel flag. > .It Fl m Ar minfree > > Modified: head/sbin/tunefs/tunefs.c > ============================================================================== > --- head/sbin/tunefs/tunefs.c Fri Jan 25 20:02:55 2019 (r343448) > +++ head/sbin/tunefs/tunefs.c Fri Jan 25 20:07:18 2019 (r343449) > @@ -189,7 +189,7 @@ main(int argc, char *argv[]) > name = "volume label"; > Lvalue = optarg; > i = -1; > - while (isalnum(Lvalue[++i])); > + while (isalnum(Lvalue[++i]) || Lvalue[i] == '_'); > if (Lvalue[i] != '\0') { > errx(10, > "bad %s. Valid characters are alphanumerics.", ^^^^^^^^^^^^ This message is now incorrect. -- Rod Grimes rgrimes@freebsd.org