From owner-freebsd-current@freebsd.org Thu Nov 21 22:11:06 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F2C651CC2FA for ; Thu, 21 Nov 2019 22:11:06 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from jax4mhob23.registeredsite.com (jax4mhob23.registeredsite.com [64.69.218.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.registeredsite.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Jv096Q3Zz41TB for ; Thu, 21 Nov 2019 22:11:05 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from mailpod.hostingplatform.com ([10.30.77.35]) by jax4mhob23.registeredsite.com (8.14.4/8.14.4) with ESMTP id xALMB09D095464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 21 Nov 2019 17:11:00 -0500 Received: (qmail 41212 invoked by uid 0); 21 Nov 2019 22:11:00 -0000 X-TCPREMOTEIP: 99.253.169.68 X-Authenticated-UID: dclarke@blastwave.org Received: from unknown (HELO ?172.16.35.2?) (dclarke@blastwave.org@99.253.169.68) by 0 with ESMTPA; 21 Nov 2019 22:11:00 -0000 Subject: Re: breakage at usr.sbin/jail/Makefile To: freebsd-current@freebsd.org References: <0e3dd332-91d7-0aa1-43cb-43528db7c63a@nomadlogic.org> <20191121041317.GL5599@FreeBSD.org> <38318920-7d3b-ee08-b0d0-d6e04e03c6a3@nomadlogic.org> From: Dennis Clarke Message-ID: <3756e95b-310f-05ff-43c0-a78f8b060e82@blastwave.org> Date: Thu, 21 Nov 2019 22:10:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Thunderbird/71.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47Jv096Q3Zz41TB X-Spamd-Bar: +++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of dclarke@blastwave.org has no SPF policy when checking 64.69.218.111) smtp.mailfrom=dclarke@blastwave.org X-Spamd-Result: default: False [3.35 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; NEURAL_SPAM_MEDIUM(0.94)[0.938,0]; NEURAL_SPAM_LONG(0.98)[0.982,0]; RCVD_IN_DNSWL_NONE(0.00)[111.218.69.64.list.dnswl.org : 127.0.10.0]; R_SPF_NA(0.00)[]; DMARC_NA(0.00)[blastwave.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:19871, ipnet:64.69.218.0/23, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.53)[ipnet: 64.69.218.0/23(1.06), asn: 19871(1.67), country: US(-0.05)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 22:11:07 -0000 On 11/21/19 11:33 AM, Ed Maste wrote: > On Wed, 20 Nov 2019 at 23:19, Pete Wright wrote: >> >> the issue seems to be on my amd64 system ${LINKER_TYPE} is not defined. >> i was contemplating suggesting updating the .if clause in the Makefile >> like so: >> >> .if defined($LINKER_TYPE}) && ${LINKER_TYPE} == "bfd" && ${MACHINE} == >> "riscv" > > Yes, this is the approach I went with - Cirrus-CI started building my > proposed change last night but it wasn't finished before I was. When I > checked this morning it confirmed the fix works. In any case the best > fix here will be to resolve the underlying RISC-V binutils issue and > revert all of the workarounds. > > Note that FreeBSD's CI did not catch this issue because it builds with > -DNO_CLEAN. I also build locally with -DNO_CLEAN and wouldn't have > seen it either. In my opinion we ought to just remove the not-NO_CLEAN > case from buildworld/buildkernel. I generally look at the CI traffic to get a feel for what I *should* be seeing and thus I was baffled when my cross compile was blowing up on exactly this issue. Really I want to debug : https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242067 wherein printf seems to get down to _ldtoa.c and then confusion sets in over the in memory data for fp128 little endian data but that is another story. I can't get very far without some basic tools and at the moment the CI builds are not very useful as they barely have anything for tools in /bin or anywhere else. Not even ed? Really? In any case I did look at the RISC-V projects GNU Toolchain and I did go with a build of the latest from : https://github.com/riscv/riscv-gnu-toolchain and that did work well for a buildworld a few days ago. The buildkernel fails. So I start over as if I am fishing for code in a fast flowing stream of water where I never know what works and what doesn't the next moment. Why? Because the CI builds were not failing. Sometimes I get lucky. With r354874 and the new GNU Toolchain cross tools I get a clean buildworld and then the kernel fails. So today I will start over from scratch but I will use the GNU Toolchain from RISC-V upstream project thus : vesta# vesta# uname -apKU FreeBSD vesta 12.1-RELEASE-p1 FreeBSD 12.1-RELEASE-p1 GENERIC amd64 amd64 1201000 1201000 vesta# /opt/rv64/tools/bin/riscv64-unknown-elf-gcc --version riscv64-unknown-elf-gcc (GCC) 9.2.0 Copyright (C) 2019 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. vesta# So I will try again today and report back. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional