Date: Thu, 21 Mar 2002 14:58:43 +0200 From: Peter Pentchev <roam@ringlet.net> To: Trevor Johnson <trevor@jpj.net> Cc: ports@FreeBSD.org Subject: x11/wrapper port deinstall problem Message-ID: <20020321145843.E4812@straylight.oblivion.bg>
next in thread | raw e-mail | index | archive | help
--ytoMbUMiTKPMT3hY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, What do you think of the attached patch which will make your x11/wrapper port deinstall properly? The issue is that the deinstallation script is actually invoked *twice* - once before the deinstall and once after that. The script is supposed to distinguish the two invocations by examining its second cmdline argument, which is DEINSTALL in the first case and POST-DEINSTALL in the second. The x11/wrapper pkg-deinstall script does not try to examine it, and consequently the second invocation fails - mv(1) reports that the X.bck file does not exist, and the -f argument does not stop it from exiting with an error code of 1. Thus, pkg_delete(1) reports 'post-deinstall script failed' and aborts. Still, thanks for your work on a great (and muchly needed) wrapper port! :) G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 This sentence contradicts itself - or rather - well, no, actually it doesn'= t! Index: ports/x11/wrapper/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/x11/wrapper/Makefile,v retrieving revision 1.11 diff -u -r1.11 Makefile --- ports/x11/wrapper/Makefile 11 Mar 2002 13:08:22 -0000 1.11 +++ ports/x11/wrapper/Makefile 21 Mar 2002 06:58:29 -0000 @@ -7,7 +7,7 @@ =20 PORTNAME=3D wrapper PORTVERSION=3D 1.0 -PORTREVISION=3D 1 +PORTREVISION=3D 2 CATEGORIES=3D x11 =20 MAINTAINER=3D trevor@FreeBSD.org Index: ports/x11/wrapper/pkg-deinstall =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/x11/wrapper/pkg-deinstall,v retrieving revision 1.3 diff -u -r1.3 pkg-deinstall --- ports/x11/wrapper/pkg-deinstall 11 Mar 2002 13:04:28 -0000 1.3 +++ ports/x11/wrapper/pkg-deinstall 21 Mar 2002 06:58:11 -0000 @@ -1,2 +1,4 @@ #!/bin/sh -mv -f ${PKG_PREFIX}/bin/X.bck ${PKG_PREFIX}/bin/X +if [ -e ${PKG_PREFIX}/bin/X.bck ]; then + mv ${PKG_PREFIX}/bin/X.bck ${PKG_PREFIX}/bin/X +fi --ytoMbUMiTKPMT3hY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjyZ2QIACgkQ7Ri2jRYZRVNxlgCglEbiliSz8a50W/IHgWzj54Ys 40YAn1/1OgeUpqfCh/bBvEKd2D7NpxSc =4nWO -----END PGP SIGNATURE----- --ytoMbUMiTKPMT3hY-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020321145843.E4812>