From owner-freebsd-threads@FreeBSD.ORG  Tue Apr 27 06:47:10 2004
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E095A16A4CE
	for <threads@FreeBSD.org>; Tue, 27 Apr 2004 06:47:10 -0700 (PDT)
Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B515643D64
	for <threads@FreeBSD.org>; Tue, 27 Apr 2004 06:47:10 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 32559 invoked from network); 27 Apr 2004 13:47:10 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <kaakun@highway.ne.jp>; 27 Apr 2004 13:47:10 -0000
Received: from slimer.baldwin.cx (slimer.baldwin.cx [192.168.0.16])
	by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i3RDknLF007021;
	Tue, 27 Apr 2004 09:46:52 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: David Xu <davidxu@FreeBSD.org>
Date: Tue, 27 Apr 2004 09:43:56 -0400
User-Agent: KMail/1.6
References: <Pine.GSO.4.10.10404221759560.15790-100000@pcnet5.pcnet.com>
	<200404231357.23096.jhb@FreeBSD.org> <408D0373.8050006@freebsd.org>
In-Reply-To: <408D0373.8050006@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200404270943.56789.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
cc: threads@FreeBSD.org
Subject: Re: kse_release and kse_wakeup problem (fwd)
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Apr 2004 13:47:11 -0000

On Monday 26 April 2004 08:41 am, David Xu wrote:
> I think libthr will encounters same problem as libpthread with new sleep
> queue code, because mtx is released too early in msleep before thread
> markes itself as ON_SLEEPQ, thr_suspend and thr_wakeup have same race
> window as kse_release and kse_wakeup. Any code wants to put synchronous
> bit in td_flags like these codes will be broken.

Nope.  libthr msleep's on PROC_LOCK.  It can do this because it holds both 
sched_lock and proc_lock when writing to its thread flag, so it can hold just 
the proc_lock for reading the flag, including msleep/wakeup.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org