From owner-p4-projects  Mon Apr  1 11:20:35 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id EE11237B417; Mon,  1 Apr 2002 11:20:21 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from rwcrmhc54.attbi.com (rwcrmhc54.attbi.com [216.148.227.87])
	by hub.freebsd.org (Postfix) with ESMTP
	id C8C7937B438; Mon,  1 Apr 2002 11:20:18 -0800 (PST)
Received: from InterJet.elischer.org ([12.232.206.8])
          by rwcrmhc54.attbi.com
          (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP
          id <20020401192018.ODHE1214.rwcrmhc54.attbi.com@InterJet.elischer.org>;
          Mon, 1 Apr 2002 19:20:18 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA15855;
	Mon, 1 Apr 2002 11:16:10 -0800 (PST)
Date: Mon, 1 Apr 2002 11:16:10 -0800 (PST)
From: Julian Elischer <julian@elischer.org>
To: John Baldwin <jhb@FreeBSD.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 8807 for review
In-Reply-To: <200204011912.g31JCAA22362@freefall.freebsd.org>
Message-ID: <Pine.BSF.4.21.0204011115520.15571-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

I ansify every declaration I come across....


On Mon, 1 Apr 2002, John Baldwin wrote:

> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=8807
> 
> Change 8807 by jhb@jhb_laptop on 2002/04/01 11:11:59
> 
> 	Bah, K&R function declarations suck. :)  I missed removing the flag
> 	argument the second time.  Bite the bullet and just use ANSI
> 	declarations for suser() and suser_cred().
> 
> Affected files ...
> 
> ... //depot/projects/smpng/sys/kern/kern_prot.c#53 edit
> 
> Differences ...
> 
> ==== //depot/projects/smpng/sys/kern/kern_prot.c#53 (text+ko) ====
> 
> @@ -1265,9 +1265,7 @@
>   * specify jail interaction.
>   */
>  int
> -suser_cred(cred, flag)
> -	struct ucred *cred;
> -	int flag;
> +suser_cred(struct ucred *cred, int flag)
>  {
>  
>  	if (!suser_enabled)
> @@ -1284,9 +1282,7 @@
>   * caller, promoting binary compatibility.
>   */
>  int
> -suser(td)
> -	struct thread *td;
> -	int flag;
> +suser(struct thread *td)
>  {
>  
>  	return (suser_cred(td->td_ucred, 0));
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message