From owner-cvs-all Sun Dec 19 13:56:54 1999 Delivered-To: cvs-all@freebsd.org Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4]) by hub.freebsd.org (Postfix) with ESMTP id 2088715226; Sun, 19 Dec 1999 13:56:49 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.9.3/8.9.3) id NAA38840; Sun, 19 Dec 1999 13:56:46 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <199912192156.NAA38840@gndrsh.dnsmgr.net> Subject: Re: cvs commit: src/sys/net if_ethersubr.c if_fddisubr.c if_iso88025subr.c src/sys/netinet raw_ip.c udp_usrreq.c In-Reply-To: from Brian Fundakowski Feldman at "Dec 19, 1999 00:47:52 am" To: green@FreeBSD.org (Brian Fundakowski Feldman) Date: Sun, 19 Dec 1999 13:56:46 -0800 (PST) Cc: wollman@khavrinen.lcs.mit.edu (Garrett Wollman), cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > On Sat, 18 Dec 1999, Garrett Wollman wrote: > > > < said: > > > > > Log: > > > M_PREPEND-related cleanups (unregisterifying struct mbuf *s). > > > > Reviewed by: ???? > > I'm pretty certain that I don't have a sign on me that says "kick me", or > "I cannot commit a simple, thoroughly tested change without a review." We all have worn that sign at one time or another, you know those collections of little orange cones in the corner we all have. Well, to reduce the rate of growth of those it is usually best to drop the attitude ``I am above error in this simple case'' and have _all_ patches reviewed, no matter how trivial. I know it sure reduced my pile of little orange hats over the year, though I still get one once in a while :-). Just ask any senior committer (thats someone who has been around more than 1/2 the life of the project) how many times they could have saved themselves and everyone else some grief had they sent that 10 line patch off for review before commititing it. -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message