From owner-dev-commits-src-all@freebsd.org Sat May 1 21:18:43 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 328ED638B54; Sat, 1 May 2021 21:18:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FXhtW0wHvz4v88; Sat, 1 May 2021 21:18:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1230A1EA86; Sat, 1 May 2021 21:18:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 141LIhOn089806; Sat, 1 May 2021 21:18:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 141LIhLa089805; Sat, 1 May 2021 21:18:43 GMT (envelope-from git) Date: Sat, 1 May 2021 21:18:43 GMT Message-Id: <202105012118.141LIhLa089805@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Justin Hibbits Subject: git: be48fe60009e - main - powerpc/xive: Remove POWER9 DD1 IRQ bits MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: be48fe60009ed0b45f5675a26e68df2f50ca382a Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 May 2021 21:18:43 -0000 The branch main has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=be48fe60009ed0b45f5675a26e68df2f50ca382a commit be48fe60009ed0b45f5675a26e68df2f50ca382a Author: Justin Hibbits AuthorDate: 2021-04-26 18:04:42 +0000 Commit: Justin Hibbits CommitDate: 2021-05-01 21:18:02 +0000 powerpc/xive: Remove POWER9 DD1 IRQ bits The OPAL_XIVE_*_VIA_IFW flags are used only for POWER9 DD1, which we don't support. Noticed while perusing Linux and skiboot git logs. --- sys/powerpc/powernv/xive.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sys/powerpc/powernv/xive.c b/sys/powerpc/powernv/xive.c index 15b8920fe267..77467dc9fcd7 100644 --- a/sys/powerpc/powernv/xive.c +++ b/sys/powerpc/powernv/xive.c @@ -170,8 +170,6 @@ struct xive_irq { uint32_t lirq; uint64_t vp; uint64_t flags; -#define OPAL_XIVE_IRQ_EOI_VIA_FW 0x00000020 -#define OPAL_XIVE_IRQ_MASK_VIA_FW 0x00000010 #define OPAL_XIVE_IRQ_SHIFT_BUG 0x00000008 #define OPAL_XIVE_IRQ_LSI 0x00000004 #define OPAL_XIVE_IRQ_STORE_EOI 0x00000002 @@ -598,9 +596,7 @@ xive_eoi(device_t dev, u_int irq, void *priv) } else rirq = priv; - if (rirq->flags & OPAL_XIVE_IRQ_EOI_VIA_FW) - opal_call(OPAL_INT_EOI, irq); - else if (rirq->flags & OPAL_XIVE_IRQ_STORE_EOI) + if (rirq->flags & OPAL_XIVE_IRQ_STORE_EOI) xive_write_mmap8(rirq->eoi_page + XIVE_IRQ_STORE_EOI, 0); else if (rirq->flags & OPAL_XIVE_IRQ_LSI) xive_read_mmap8(rirq->eoi_page + XIVE_IRQ_LOAD_EOI);