From owner-cvs-all@FreeBSD.ORG Thu Mar 29 20:58:07 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7B2BF16A405 for ; Thu, 29 Mar 2007 20:58:07 +0000 (UTC) (envelope-from mmakonnen@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.171]) by mx1.freebsd.org (Postfix) with ESMTP id 0CC3713C4B7 for ; Thu, 29 Mar 2007 20:58:06 +0000 (UTC) (envelope-from mmakonnen@gmail.com) Received: by ug-out-1314.google.com with SMTP id 71so629351ugh for ; Thu, 29 Mar 2007 13:58:06 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=IIJDgn9Cdo3pGf47uFsrfVkpSwX2XW7XVjikOfoX/6BSqv5Z+6djwwlk4v2nlJiIcdOPmCHiEND5LM3CRoDa05dkUZU/H2LxtTLEirIc8qruIKL+s9QpqJZcfiRVOYGankJW75nhBYQzu6xpkiSKLOZZh4MvvgcAeRJ1PW4dwS8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ICZ/9NwWmVqLpAwS4EpLkuvLkwWbWo2BkAdgI1ar85spLsVwS9kpypq+iSA5cac3Y9VjTVW0W8U6cqixvzpo54JHoMI/AH3sBy7+UQbWpAEenKnKi1+UTkelsr8qfj7s4kjLMjpiWHKSou7Jh8VU5EoKcjGExNRE8u5CDYub5oA= Received: by 10.114.89.1 with SMTP id m1mr409162wab.1175200169840; Thu, 29 Mar 2007 13:29:29 -0700 (PDT) Received: by 10.114.106.15 with HTTP; Thu, 29 Mar 2007 13:29:29 -0700 (PDT) Message-ID: <584bfc3f0703291329g3f5bc26dx60b0cbaa9811d19d@mail.gmail.com> Date: Thu, 29 Mar 2007 23:29:29 +0300 From: "Mike Telahun Makonnen" To: "Andrey Chernov" , "John Baldwin" , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org In-Reply-To: <20070329195857.GA11737@nagual.pp.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200703291055.l2TAtYu4038445@repoman.freebsd.org> <20070329172409.GA38703@rogue.navcom.lan> <20070329190812.GA11138@nagual.pp.ru> <200703291534.46417.jhb@freebsd.org> <20070329195857.GA11737@nagual.pp.ru> Cc: Subject: Re: cvs commit: src/etc network.subr X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2007 20:58:07 -0000 On 3/29/07, Andrey Chernov wrote: > On Thu, Mar 29, 2007 at 03:34:45PM -0400, John Baldwin wrote: > > The change in v1.28 fixed a similar warning where you'd get something like > > > > /etc/rc.d/dhclient: WARNING: $background_dhclient_bge0 is not set properly > > > > (where bge0 is an interface name). 1.28 fixed the warning for me, but I don't > > use background_dhclient and have none of the variables set. Maybe Andrey is > > seeing a warning in the non-default case when a variable is set? > > I have plain DHCP and don't use background_dhclient too. I wonder why > somebody have not see it. Look at this lines from v1.28: Yeah apologies, you're right, it's not the same bug. However, the fix is still wrong. The correct fix is to put the sample fxp line a comment. The reason your fix is wrong is because get_if_var() is supposed to give the default value only if the variable it's looking for is unset. If it is set it is supposed to give you whatever value it's set to. In the fxp0 case, it is erroneously set to null (i.e ""), so checkyesno() correctly complains that it is set to an improper value (which it is). So, what you should do is back your fix out and comment out the fxp0 line in /etc/defaults/rc.conf. Cheers. Mike.