From owner-freebsd-net@FreeBSD.ORG Sun Aug 15 17:24:27 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EBF3510656A4; Sun, 15 Aug 2010 17:24:26 +0000 (UTC) (envelope-from prvs=1843ec5375=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) by mx1.freebsd.org (Postfix) with ESMTP id 522838FC14; Sun, 15 Aug 2010 17:24:26 +0000 (UTC) X-MDAV-Processed: mail1.multiplay.co.uk, Sun, 15 Aug 2010 18:13:49 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Sun, 15 Aug 2010 18:13:49 +0100 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mail1.multiplay.co.uk X-Spam-Level: X-Spam-Status: No, score=-5.0 required=6.0 tests=USER_IN_WHITELIST shortcircuit=ham autolearn=disabled version=3.2.5 Received: from r2d2 by mail1.multiplay.co.uk (MDaemon PRO v10.0.4) with ESMTP id md50011070254.msg; Sun, 15 Aug 2010 18:13:49 +0100 X-Authenticated-Sender: Killing@multiplay.co.uk X-MDRemoteIP: 188.220.16.49 X-Return-Path: prvs=1843ec5375=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: From: "Steven Hartland" To: "Andre Oppermann" , References: <4C67EBCC.7000507@freebsd.org> Date: Sun, 15 Aug 2010 18:13:43 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=response Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 Cc: Subject: Re: TCP inflight limiter disabled and scheduled for removal X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Aug 2010 17:24:27 -0000 Will be glad to see this go, only ever caused performance issues here :( Regards Steve ----- Original Message ----- From: "Andre Oppermann" To: Sent: Sunday, August 15, 2010 2:29 PM Subject: TCP inflight limiter disabled and scheduled for removal > FYI the TCP inflight limiter is now disabled by default and will be > removed soon. It was interfering with the congestion control algorithms > and the upcoming pluggable congestion control framework allows other > approaches to be selected at runtime. > > -------- Original Message -------- > Subject: svn commit: r211315 - head/sys/netinet > Date: Sat, 14 Aug 2010 20:40:55 +0000 (UTC) > From: Andre Oppermann > To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org > > Author: andre > Date: Sat Aug 14 20:40:55 2010 > New Revision: 211315 > URL: http://svn.freebsd.org/changeset/base/211315 > > Log: > Disable TCP inflight limiter by default. > > It was experimental and interferes with the normal congestion control > algorithms by instating a separate, possibly lower, ceiling for the > amount of data that is in flight to the remote host. With high speed > internet connections the inflight limit frequently has been estimated > too low due to the noisy nature of the RTT measurements. > > This code gives way for the upcoming pluggable congestion control > framework. It is the task of the congestion control algorithm to > set the congestion window and amount of inflight data without external > interference. > > Reviewed by: lstewart > MFC after: 1 week > Removal after: 1 month > > Modified: > head/sys/netinet/tcp_subr.c > > Modified: head/sys/netinet/tcp_subr.c > ============================================================================== > --- head/sys/netinet/tcp_subr.c Sat Aug 14 20:12:10 2010 (r211314) > +++ head/sys/netinet/tcp_subr.c Sat Aug 14 20:40:55 2010 (r211315) > @@ -221,7 +221,7 @@ SYSCTL_VNET_INT(_net_inet_tcp, OID_AUTO, > SYSCTL_NODE(_net_inet_tcp, OID_AUTO, inflight, CTLFLAG_RW, 0, > "TCP inflight data limiting"); > > -static VNET_DEFINE(int, tcp_inflight_enable) = 1; > +static VNET_DEFINE(int, tcp_inflight_enable) = 0; > #define V_tcp_inflight_enable VNET(tcp_inflight_enable) > SYSCTL_VNET_INT(_net_inet_tcp_inflight, OID_AUTO, enable, CTLFLAG_RW, > &VNET_NAME(tcp_inflight_enable), 0, > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.