From owner-svn-src-projects@FreeBSD.ORG Mon Dec 17 21:23:15 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3D5706B9; Mon, 17 Dec 2012 21:23:15 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 69A478FC15; Mon, 17 Dec 2012 21:23:13 +0000 (UTC) Received: by mail-we0-f182.google.com with SMTP id u54so3032069wey.13 for ; Mon, 17 Dec 2012 13:23:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=G8ZuIe53sZA4D4rtiMJ2PnMFDe8WqiSFVLps34ULkEc=; b=zMcszHf1o0Dv9OxWxK12rTGBHcP4Pvs9hELcXfd+8GmL4OPrsOTi3AgsMyMBhEhbKG GAYDbGnAEf2DkrUOLbcFWWMv9yK5H/sD3TvLGz779BjLQwLgxehnNY4ZJb6p3hkVWBPE /CLdDHT6t0xm78WLETfRtBZFUjPEqdhB+QoUInmx+eikKlbLJ4e3CMPMd0sndqYuPtli kqzOSwii00UqwDkaiODQZ46DKB1466+DjriwIOW1P/XYRrQVhBIn48XVr9jiC/gRd52I jdYqc+IuwfHm76eyJF6Wo5zyHHA5dxxQpkzidC9z6U8wDOlw9/XJFxinL3hmE9AHq6yO E2rQ== Received: by 10.194.76.165 with SMTP id l5mr19799034wjw.14.1355779393272; Mon, 17 Dec 2012 13:23:13 -0800 (PST) Received: from mavbook.mavhome.dp.ua (mavhome.mavhome.dp.ua. [213.227.240.37]) by mx.google.com with ESMTPS id eo10sm14462794wib.9.2012.12.17.13.23.10 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 17 Dec 2012 13:23:12 -0800 (PST) Sender: Alexander Motin Message-ID: <50CF8D3D.6030906@FreeBSD.org> Date: Mon, 17 Dec 2012 23:23:09 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120628 Thunderbird/13.0.1 MIME-Version: 1.0 To: John Baldwin Subject: Re: svn commit: r244249 - projects/calloutng/sys/dev/syscons References: <201212151044.qBFAiG70038633@svn.freebsd.org> <201212171509.55216.jhb@freebsd.org> In-Reply-To: <201212171509.55216.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2012 21:23:15 -0000 On 17.12.2012 22:09, John Baldwin wrote: > On Saturday, December 15, 2012 5:44:16 am Alexander Motin wrote: >> Author: mav >> Date: Sat Dec 15 10:44:16 2012 >> New Revision: 244249 >> URL: http://svnweb.freebsd.org/changeset/base/244249 >> >> Log: >> Switch syscons from timeout() to callout_reset_flags() and specify that >> precision is not important there -- anything from 20 to 30Hz will be fine. >> >> Modified: >> projects/calloutng/sys/dev/syscons/syscons.c >> projects/calloutng/sys/dev/syscons/syscons.h >> >> Modified: projects/calloutng/sys/dev/syscons/syscons.c >> > ============================================================================== >> --- projects/calloutng/sys/dev/syscons/syscons.c Sat Dec 15 10:30:06 2012 > (r244248) >> +++ projects/calloutng/sys/dev/syscons/syscons.c Sat Dec 15 10:44:16 2012 > (r244249) >> @@ -504,6 +504,8 @@ sc_attach_unit(int unit, int flags) >> >> sc = sc_get_softc(unit, flags & SC_KERNEL_CONSOLE); >> sc->config = flags; >> + callout_init(&sc->ctimeout, FALSE); >> + callout_init(&sc->cblink, FALSE); > > Did you change the calling conventions for callout_init() in this branch? In > HEAD the second argument is a flags variable (albeit with only a single flag > defined: CALLOUT_MPSAFE). Thus, the common usage is to use 'callout_init(.., > 0);' for callouts that need Giant and 'callout_init(..., CALLOUT_MPSAFE);' for > those that do not need Giant. No, I haven't. But man page still talks about "FALSE" value for mpsafe argument and that confused me. Fixed. Thanks. -- Alexander Motin