From nobody Wed Oct 1 00:56:24 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cbxMD5LLlz69hGH; Wed, 01 Oct 2025 00:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cbxMD4bFCz4M6N; Wed, 01 Oct 2025 00:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759280184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QZ9dza/JDp94PlUu7olh0aUrx81KANsAEADWx88gfrM=; b=kT5gY3kWa3jyfULqxRG4HbjANm77rKqVUEu8gnLAgcaSo2gLHSsZ3gH3caUlPPhpydXLro xT9GaedMLXk/lvD0uyuUOuQh+vrfSj4/jZUcov/efoKDgFSmkJROg8EWaAc+rYLZiQgacn iUJsuCD9rdFRvRLf2AgEd62xXI3zG6sKzmKzlNF8WD0rQEel2GT4ZsuQGd+xgCkRJf9mHA 2QvRH5KzM+q7/oC7H2SdjnocWv6V19fEetM1/xGDcFHFm9RpnRUHKC6Aw0Xd67b6zBCm5v cw4l1GVeqm4PxehYlIa+O5XS/eZO6jM54fuIxSNmR8Vxasi7d6X4Lnx4gXCqcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759280184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QZ9dza/JDp94PlUu7olh0aUrx81KANsAEADWx88gfrM=; b=yUrTJRWRP0b6SSv3bhqbwVeipceRR69Kvs8Iv6clRWxVswddJcCx+lQW+SFHj0MjOzEOVw DGFoFktVBuz+/Mw59JmMoz3DROBD/ICwA3vbf188zzMgLsMd/zow8MY1zx7PFceSgxCWBR 8BohlAag1Ha8vSMOde+h2fzK7B/SClQbA5kAzfXRSACNJ0kX5MYEj1l3IljLZcGcZ1hoBP wwqHwzg7UmH2sVOsAstAVLjEnvM2pSVtUfQWTONjwhKjeIY1x7Aq3jaycF5ZM1DILvf6G6 gWZYE5aenbpz05TYfXUb6JNd4gEUT14UKT2z7A+cPfo2ycncQTBIIvhWhWdW1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759280184; a=rsa-sha256; cv=none; b=wxftVAWblE7cUjnJu6wEAXNDFybzHSR4sBaVWMS3yWbVCBa4qADTvl6HYsgHGdN/Up+Wbj hph50CWBFQmvdrfyUuNHPLJXZXkKpL0aZm6IsO6Wq9f2FkZfMJ2W9lbbRZ6BL4RurdCMcF jGk49fDeJ/TcO0vzfa7qPXvLqF9+o3qE8UXGf2o8wiGjObOmLNnAqPaV34v3svvT2saQvs Dq8RzQlhfIvCmDrX7WjQU+HLppdBu+GfHvauF1fzCbzP/fTQx/YIwSEy+VVSHZm7rydakH K3gviaDYjmXAcGazFmL7ZxYG2TWOhiii55WY59FOtX4wQyOihvyiIbjEYpZZeg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cbxMD4BFZz10xW; Wed, 01 Oct 2025 00:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5910uOSt024218; Wed, 1 Oct 2025 00:56:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5910uOR9024215; Wed, 1 Oct 2025 00:56:24 GMT (envelope-from git) Date: Wed, 1 Oct 2025 00:56:24 GMT Message-Id: <202510010056.5910uOR9024215@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: 4771b65fde48 - stable/15 - rpc_generic.c: Fix a rpcbind core dump when rpcinfo is done List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 4771b65fde4893ffbb36f53fcd20e3b850a50b6a Auto-Submitted: auto-generated The branch stable/15 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=4771b65fde4893ffbb36f53fcd20e3b850a50b6a commit 4771b65fde4893ffbb36f53fcd20e3b850a50b6a Author: Rick Macklem AuthorDate: 2025-09-28 14:56:17 +0000 Commit: Rick Macklem CommitDate: 2025-10-01 00:52:46 +0000 rpc_generic.c: Fix a rpcbind core dump when rpcinfo is done Commit c5d671b added netlink support to server side rpcbind. However it did not add a case for AF_NETLINK to __rpc_taddr2uaddr_af(). (Reported as PR#289625.) As such, without this patch the r_addr field of the netlink rbllist is NULL, which causes a crash in svc_sendreply() for a Dump query (what rpcinfo does). PR: 289625 (cherry picked from commit 70730cd21c9f2b0a80ff07e4491c0fe30f2d87c5) --- lib/libc/rpc/rpc_generic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libc/rpc/rpc_generic.c b/lib/libc/rpc/rpc_generic.c index 0e563f6a5996..8019f2d8f236 100644 --- a/lib/libc/rpc/rpc_generic.c +++ b/lib/libc/rpc/rpc_generic.c @@ -610,6 +610,10 @@ __rpc_taddr2uaddr_af(int af, const struct netbuf *nbuf) return NULL; break; #endif + case AF_NETLINK: + if (asprintf(&ret, "%s", (char *)nbuf->buf) < 0) + return NULL; + break; case AF_LOCAL: sun = nbuf->buf; if (asprintf(&ret, "%.*s", (int)(sun->sun_len -