From nobody Wed Apr 29 14:49:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g5Kvw44d3z6bkwJ for ; Wed, 29 Apr 2026 14:49:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g5Kvw2QrRz4KWg for ; Wed, 29 Apr 2026 14:49:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777474188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1HM+ebOmbs7kosrzv83wo3/bAwmsnXlnpZeN4/Zt9N0=; b=TQoCgwSsdVIVldDDsekTiTd9Yi6sfDUTvAbVARdkpOq6t6sXDalwagWj+EC5C4ce+kholy eYNJF9LnWDH3P2gjXnFZYuQWlK85GUzq7Usqds03rjq9T9F3ARVqgHi9bdCOAwckcBza3m T14JpOSPLt/OukJvWmGsD9x9IN363FynfuluN0z2Dh3OBbpVXjmjGFu3ZQurG8FP1sdFiV ZU/bStUgY9SQAPONsqrzG4llWc0kp4QZXD9QlnpMjQ0508ManOkSDS7W6ZkOtdKQHKXrVk 2eEXuD2TsA2YXCCj8y/27BI2xaQ6zOeQugU38EKxh2a4tAI3b60KwTO6T1kdiA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777474188; a=rsa-sha256; cv=none; b=Rm0kEKn+1nFiANP9N/hnGNJtY2ai/o/VTSXz6I4qsZnW3nsvY/j7+wOq0ni7u4kYP/0Z+j qQt5J+ndWm3C6QTv9sqIDHb5jWWcrsKyyIwe7RoaaKa0aCsiW8QJr5kAc/kW5Kw1F+D4wB HZy1B4sCEkvjUAu6GcCVZ0hBLwU7t5GfzEeZgC6ZM4ITXFfxa4zlfBphyjCccSiQp+sQjc Rz8SingA9x4TZBRrqILiKh/Fm/zqvSw1ezdJLvmYab5EOdkZWR2tkUissMuMj4vNMwXHIp wbkOPicaTSDG00IlqeKD4BoCZn2GgSkaAWFhqX/Um33xIR/vzRNmCmx1oZOrqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777474188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1HM+ebOmbs7kosrzv83wo3/bAwmsnXlnpZeN4/Zt9N0=; b=pZY3PX9z2okOfrp+zxDt9++Hoq8VEfSxjZAI++yi9+PCpZmMvR/T3gGHZeBWHzb6X0aZ+e i5Yk4FYOIIWjpevyvEVn9Y7b5PYSy+A9pfhVd3S+UuodQsjQRu2QNede715mjNZT9BUuff RG1E7wTW6iWdjNY6RSy/bOmtp2j10zPLv6/U4C1yBdSTjSTJjMrIt/TfQTaea3dxWUuH87 19tXqSTZ9a5Ecwo//Tcq/yYI7xKzOJQqQJ3Y8OTxgirZ2EtLHXQsuJ4zHPXGxQ+meBXyyY 1XStg/QRDHnXeGAvRbfUh6TOMLOlb35oJM8b42Vk8eGVcA+6e7BS30TlwDMmQA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g5Kvw0jSnzlbl for ; Wed, 29 Apr 2026 14:49:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cf3f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Apr 2026 14:49:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Mariusz Zaborski From: Mark Johnston Subject: git: a5cb4863d65a - releng/14.4 - libnv: switch fd_wait() from select(2) to poll(2) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: a5cb4863d65a64cc16a81f49b35b944d9b9b14f2 Auto-Submitted: auto-generated Date: Wed, 29 Apr 2026 14:49:47 +0000 Message-Id: <69f21a8b.3cf3f.694d20f5@gitrepo.freebsd.org> The branch releng/14.4 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=a5cb4863d65a64cc16a81f49b35b944d9b9b14f2 commit a5cb4863d65a64cc16a81f49b35b944d9b9b14f2 Author: Mariusz Zaborski AuthorDate: 2026-04-28 14:35:10 +0000 Commit: Mark Johnston CommitDate: 2026-04-28 20:33:58 +0000 libnv: switch fd_wait() from select(2) to poll(2) The previous implementation used FD_SET() on a stack-allocated fd_set, which is an out-of-bounds write whenever the socket fd is >= FD_SETSIZE (1024). Approved by: so Security: FreeBSD-SA-26:16.libnv Security: CVE-2026-39457 Reported by: Joshua Rogers of AISLE Research Team (https://aisle.com/) Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D56689 --- lib/libnv/msgio.c | 12 +++---- lib/libnv/tests/nvlist_send_recv_test.c | 56 +++++++++++++++++++++++++++++++++ 2 files changed, 62 insertions(+), 6 deletions(-) diff --git a/lib/libnv/msgio.c b/lib/libnv/msgio.c index 002c626647d9..d972ced3c86c 100644 --- a/lib/libnv/msgio.c +++ b/lib/libnv/msgio.c @@ -33,10 +33,10 @@ #include #include #include -#include #include #include +#include #include #include #include @@ -87,14 +87,14 @@ msghdr_add_fd(struct cmsghdr *cmsg, int fd) static void fd_wait(int fd, bool doread) { - fd_set fds; + struct pollfd pfd; PJDLOG_ASSERT(fd >= 0); - FD_ZERO(&fds); - FD_SET(fd, &fds); - (void)select(fd + 1, doread ? &fds : NULL, doread ? NULL : &fds, - NULL, NULL); + pfd.fd = fd; + pfd.events = doread ? POLLIN : POLLOUT; + pfd.revents = 0; + (void)poll(&pfd, 1, -1); } static int diff --git a/lib/libnv/tests/nvlist_send_recv_test.c b/lib/libnv/tests/nvlist_send_recv_test.c index cd97ccb6b9b9..c60428c79978 100644 --- a/lib/libnv/tests/nvlist_send_recv_test.c +++ b/lib/libnv/tests/nvlist_send_recv_test.c @@ -28,6 +28,8 @@ #include #include +#include +#include #include #include #include @@ -534,6 +536,59 @@ ATF_TC_BODY(nvlist_send_recv__send_nvlist__stream, tc) nvlist_send_recv__send_nvlist(SOCK_STREAM); } +/* + * Regression test for fd_wait(): the previous select(2)-based implementation + * called FD_SET() unconditionally, which is an out-of-bounds stack write when + * the socket fd is >= FD_SETSIZE. Force the socketpair fds above FD_SETSIZE + * and verify a full nvlist round-trip still works. + */ +ATF_TC_WITHOUT_HEAD(nvlist_send_recv__highfd); +ATF_TC_BODY(nvlist_send_recv__highfd, tc) +{ + struct rlimit rl; + nvlist_t *nvl; + int socks[2], hi_send, hi_recv, status; + pid_t pid; + + hi_send = FD_SETSIZE + 5; + hi_recv = FD_SETSIZE + 6; + + rl.rlim_cur = rl.rlim_max = hi_recv + 1; + if (setrlimit(RLIMIT_NOFILE, &rl) != 0) + atf_tc_skip("cannot raise RLIMIT_NOFILE: %s", strerror(errno)); + + ATF_REQUIRE(socketpair(PF_UNIX, SOCK_STREAM, 0, socks) == 0); + ATF_REQUIRE(dup2(socks[0], hi_recv) == hi_recv); + ATF_REQUIRE(dup2(socks[1], hi_send) == hi_send); + (void)close(socks[0]); + (void)close(socks[1]); + + pid = fork(); + ATF_REQUIRE(pid >= 0); + if (pid == 0) { + /* Child: send. */ + (void)close(hi_recv); + nvl = nvlist_create(0); + nvlist_add_string(nvl, "key", "value"); + if (nvlist_send(hi_send, nvl) != 0) + err(EXIT_FAILURE, "nvlist_send"); + nvlist_destroy(nvl); + _exit(0); + } + + (void)close(hi_send); + nvl = nvlist_recv(hi_recv, 0); + ATF_REQUIRE(nvl != NULL); + ATF_REQUIRE(nvlist_error(nvl) == 0); + ATF_REQUIRE(nvlist_exists_string(nvl, "key")); + ATF_REQUIRE(strcmp(nvlist_get_string(nvl, "key"), "value") == 0); + nvlist_destroy(nvl); + + ATF_REQUIRE(waitpid(pid, &status, 0) == pid); + ATF_REQUIRE(status == 0); + (void)close(hi_recv); +} + ATF_TC_WITHOUT_HEAD(nvlist_send_recv__send_closed_fd__dgram); ATF_TC_BODY(nvlist_send_recv__send_closed_fd__dgram, tc) { @@ -737,6 +792,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, nvlist_send_recv__send_nvlist__dgram); ATF_TP_ADD_TC(tp, nvlist_send_recv__send_nvlist__stream); + ATF_TP_ADD_TC(tp, nvlist_send_recv__highfd); ATF_TP_ADD_TC(tp, nvlist_send_recv__send_closed_fd__dgram); ATF_TP_ADD_TC(tp, nvlist_send_recv__send_closed_fd__stream); ATF_TP_ADD_TC(tp, nvlist_send_recv__send_many_fds__dgram);