From nobody Tue Jan 28 23:20:51 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YjLr62WgRz5mKJm; Tue, 28 Jan 2025 23:20:54 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YjLr61xFXz3QQP; Tue, 28 Jan 2025 23:20:54 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738106454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IxfBpig+vgkjLkWA4cDhK3nBz/Ni4rIj11tbFZWNM8A=; b=EDvE6dYfwv8UlSu7VlaidQHMxQFbrfp2pkBuo/WbRLPxpRKJq6gKGqKE0o1lstvaKv3KVb 0YmJI+3W+gZQeB1KjBNg7y2c1Zs64YqmrviCHdOOd77u8xCnYn41qe+CbRXd/FdFJWKwak 69FSVyzVpnEfYt5Z8kBuzrjV2fFeCdx2/dO5QCI4qw4gh6PM9TCE0e6yQ/0s+fCEoPSldC w++0Jimr36uiREJ9JkJQprBKGNALb9feN41TIsU4O5OssHUASOxbbGVE00HC45a3r2WOiA 8zGCWatV5fUZt37hfbfyrHJUZwVMXH+vnMPBIFY7DiL7NP9xwkqbp0wAfmm/1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738106454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IxfBpig+vgkjLkWA4cDhK3nBz/Ni4rIj11tbFZWNM8A=; b=KHK0HMMn7I+FtkrjOwM0/EzPxItAspS6Ia8cDOgqp+RWpVHr3oB+WupZwmwSpG8ZWzuZpD UJpS2tVTRb0tF3zphdY/KvOZwSyXv3UV3dZsueAsAieKtv9mcANZP0rhbF7De8WOUeUafK iFYu2wQVizXOemoc+lpC+a0Ilod36tY11ZZHPOAFhzW1GyjPthAUDNLYMaH7XM7uBuZqZN LPMADUJ0RWBIE6XXY4SxrzH4sYAdtaj2RAM/NhU5iOWO2BSE+45gVL2YncCDFgHX3n2NKb bFB5yA8Jipd+pO0trLs2NgqbCpVcuJqJqFl2pFeuNZZA/DGuFyXbU8IVNwyOVA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738106454; a=rsa-sha256; cv=none; b=QYK0ggE8Qp2oH1J9Zzqzmwgby18ed8fHAkB1HYDI7j72BeRLsKi2FL7+5BinWZoNLK7Q38 2BhrsTOyjRsVUSGmnw8GVX34N1JOHQ/e265TstVOnZoq364dWPpOmVtSMR3zR6w4J4rGs3 0xu1TwNFDaXFft2fJFYHIY1FB0WYUrJ4DZceTTfpsKQin1jr/UW62YWLi1ehInpdD4+G7Y UJ4jeWiQqyTikX1qH0OPUSKqPT8GCUqkjufU4ahVeAjWZiFVEajox/6CqLlbYf6fZul/UO wu/xIcVYCiToK9qbc5tHIrftfggz+q7WFQqD1jgyISDXW7w/3xvaeU/suKUmlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R10" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YjLr60d6jz1CRn; Tue, 28 Jan 2025 23:20:54 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id D70FA6ACE3; Wed, 29 Jan 2025 00:20:51 +0100 (CET) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.9\)) Subject: Re: git: c3450ad127e9 - main - clang: re-downgrade implicit int/function declarations to warning only From: Dimitry Andric In-Reply-To: Date: Wed, 29 Jan 2025 00:20:51 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <90D8C9F1-0634-44E5-B5B5-20455A91E042@FreeBSD.org> References: <202306222111.35MLBAqB066211@gitrepo.freebsd.org> To: Jessica Clarke X-Mailer: Apple Mail (2.3731.700.6.1.9) On 28 Jan 2025, at 19:32, Jessica Clarke wrote: >=20 > On 22 Jun 2023, at 22:11, Dimitry Andric wrote: >=20 >> The branch main has been updated by dim: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc3450ad127e94d3fa67ae337310e59c0= 02f51bfc >>=20 >> commit c3450ad127e94d3fa67ae337310e59c002f51bfc >> Author: Dimitry Andric >> AuthorDate: 2023-04-25 19:24:04 +0000 >> Commit: Dimitry Andric >> CommitDate: 2023-06-22 18:22:33 +0000 >>=20 >> clang: re-downgrade implicit int/function declarations to warning = only >>=20 >> This reapplies upstream commit c0141f3c300f by Aaron Ballman: >>=20 >> Downgrade implicit int and implicit function declaration to = warning only >>=20 >> The changes in Clang 15.0.0 which enabled these diagnostics as a >> warning which defaulted to an error caused disruption for people >> working on distributions such as Gentoo. There was an explicit = request >> to downgrade these to be warning-only in Clang 15.0.1 with the >> expectation that Clang 16 will default the diagnostics to an = error. >>=20 >> See >> = https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror= -implicit-function-declaration/65213 >> for more details on the discussion. >>=20 >> See https://reviews.llvm.org/D133800 for the public review of = these >> changes. >>=20 >> As noted in the upstream discussion, there are many programs that = fail >> to configure or build correctly, if these warnings are turned into >> errors by default. >>=20 >> Note that most affected programs in ports are relatively old, and = are >> unlikely to be fixed by actually adjusting their declarations, but = by >> compiling with -std=3Dgnu89, which downgrades the errors back to = warning >> again. Lots of tedious work for very little gain. >=20 > This remains as a downstream divergence 1.5 years later, but I do not > think we should be carrying this indefinitely. Software needs to build > with upstream LLVM, and the fact that many ports do not is now biting > us for CheriBSD where we use our own external toolchain that does not > have such a diff. In my opinion this should be reverted for FreeBSD 15 > and it=E2=80=99s long time for ports people to step up or have the = broken ports > removed; we can=E2=80=99t keep going on like this with abandonware = holding back > forward progress. While I agree, at the least a full exp-run should be done, and even then you can't be entirely sure if ports that build are built the same as before, for example due to bad configure tests. So this is potentially a massive undertaking. -Dimitry