From owner-svn-ports-head@freebsd.org  Thu Jul 26 06:44:09 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE0F410444A6;
 Thu, 26 Jul 2018 06:44:08 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A8D54812D5;
 Thu, 26 Jul 2018 06:44:08 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 9BB9A16132; Thu, 26 Jul 2018 06:44:08 +0000 (UTC)
Date: Thu, 26 Jul 2018 06:44:08 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Yuri Victorovich <yuri@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r475335 - head/devel/liteide
Message-ID: <20180726064408.GC77261@FreeBSD.org>
References: <201807252025.w6PKPsxQ097871@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201807252025.w6PKPsxQ097871@repo.freebsd.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2018 06:44:09 -0000

On Wed, Jul 25, 2018 at 08:25:54PM +0000, Yuri Victorovich wrote:
> New Revision: 475335
> URL: https://svnweb.freebsd.org/changeset/ports/475335
> 
> Log:
>   devel/liteide: Update 33.3 -> 34
>   
>   Replace QT4/QT5 options with flavors.
>  
> ...
> +FLAVORS=	qt5 qt4
> +FLAVOR?=	${FLAVORS:[1]}

Is this line needed in this case?

> ...
> +.if ${FLAVOR} == qt4
> +USES+=		qt:4
> +USE_QT=		corelib gui moc_build network rcc_build uic_build webkit xml
> +PLIST_SUB+=	QT4="" NO_QT4="@comment "
> +.else
> +USES+=		qt:5
> +USE_QT=		buildtools_build core gui network printsupport widgets xml
> +PLIST_SUB+=	QT4="@comment " NO_QT4=""
> +.endif

Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
in .else branch) and never for .if ${FLAVOR} == qt5.

./danfe