Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Mar 2008 20:28:37 GMT
From:      Rui Paulo <rpaulo@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 138853 for review
Message-ID:  <200803282028.m2SKSb3c017599@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=138853

Change 138853 by rpaulo@rpaulo_epsilon on 2008/03/28 20:27:38

	Initialize sc_max before calling bm_attach().
	
	Reported by:	  ahze

Affected files ...

.. //depot/projects/soc2007/rpaulo-macbook/dev/backlight/backlight.c#15 edit

Differences ...

==== //depot/projects/soc2007/rpaulo-macbook/dev/backlight/backlight.c#15 (text+ko) ====

@@ -23,7 +23,7 @@
  * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  *
- * $P4: //depot/projects/soc2007/rpaulo-macbook/dev/backlight/backlight.c#14 $
+ * $P4: //depot/projects/soc2007/rpaulo-macbook/dev/backlight/backlight.c#15 $
  *
  */
 
@@ -206,12 +206,10 @@
 	int error;
 
 	model = backlight_match(dev);
-
+	sc->sc_max = model->bm_max;
 	error = model->bm_attach(dev);
 	if (error)
 		return (error);
-
-	sc->sc_max = model->bm_max;
 	
 	SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev),
 	    SYSCTL_CHILDREN(device_get_sysctl_tree(dev)),



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803282028.m2SKSb3c017599>