From nobody Wed May 27 21:42:09 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQjkn56QFz6fkTb for ; Wed, 27 May 2026 21:42:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQjkn3D85z3XHh for ; Wed, 27 May 2026 21:42:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779918129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rWm+gPoH5St10AxElM8H6N4pgvPe0ODq43Bw4Xs61I8=; b=xp0pyzEAp1roSyMchBIzP5T1WemgSKxGN5W13D+ViDvCZsGFN0AwJK3RxHItqmb01mwdyf /xyXK6COZJIKK4yEX6+K8es3fNJwp/ooEUFcqIyM7yhWZBmzbuM4degnMk7QK+KieF5Nd6 l8NL2UpkUdodiMx5vO01lNJ1pkkkINJC0cTfaUOptG+UxXDQlcfWRBOAtFCGAp88CZAc6n 5u1pvHTLvNdzNEiAP/uJ5tQEodBViKjfbNTyEDAlt6oThIwKPKSLfDiVSDV3UtPqh0Tcue 7crvL4NRu/swZ/dU4yEElMzVzi08/YbNgSl9dTihUQyi9Vnh8GdGhTfwjuH1mw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779918129; a=rsa-sha256; cv=none; b=KGQmSN+QFF2la2X7XsNvh0ZtwZklZNAGhi9PqdbGuN995cmKS9P7wmz7WGpNjKu7i6rMRd t1zgNDPl6YwZZnKnir2Bp1ZYVYTZBrZKVCcjl+c0qm850zsZ6cEVZmBGi9AiRxnZeVxLEQ T4UQE9CSf/qrk/btYoO2/snY9XE5AwZaN/T4eCKAMLpwyLLBMb4mKRn3Sg2DTo/bxdgbqH ft5uqK6dYUU+25AJeXcf/BHPV0OmW2w65UgJRjQA0MGsEtx9ERyyZhIqWZ8xBLSY9qsiNy RD1wROICbCUkv74Jn65vN+LgeTbwK5DRPlWQ4ZoeCChj9PVP9S5ZXqBKlIB2xA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779918129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rWm+gPoH5St10AxElM8H6N4pgvPe0ODq43Bw4Xs61I8=; b=GDFx5gch/J3O+JBqnpGTYIbcgmcGKx6tzOSveihj3ijXBTA13uu5LMk0WVwzDy0lED5zKr deMgIpPj+Iu5vmLmIPYx3JQ1PgTdL541Ywxt1PWdupWFSpAI7ZLiuOfpaOUDnR6GG70Laq 3aTwXmtLbAbjHeaZvIEyYgZHxNDlYq9m7BhJNG7CBhGTDcDJlgViJK7PPSGuJvE0V89129 ND8ousFM9Lss5FnpGoPdidh2payQGB8GHLmfrKOLRIPrmclZl5D1RxQiDkxdbLsNjov3EK 6yn0DoLTnsAYkzdnTnhkvMxmr+ML2a15UU4q45szp5hu1ar2fLnG0AcgDzi0xQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQjkn2Ht1z2bS for ; Wed, 27 May 2026 21:42:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2720f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 21:42:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Alex Richardson From: Dimitry Andric Subject: git: 4d8f612e5b26 - stable/15 - if_ovpn.c: fix use of uninitialized variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 4d8f612e5b26469732252b7f727acd9e0271f6a6 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 21:42:09 +0000 Message-Id: <6a176531.2720f.463f82a7@gitrepo.freebsd.org> The branch stable/15 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=4d8f612e5b26469732252b7f727acd9e0271f6a6 commit 4d8f612e5b26469732252b7f727acd9e0271f6a6 Author: Alex Richardson AuthorDate: 2025-09-15 22:08:43 +0000 Commit: Dimitry Andric CommitDate: 2026-05-27 21:41:03 +0000 if_ovpn.c: fix use of uninitialized variable In case we use OVPN_CIPHER_ALG_NONE, the memcpy will attempt to copy 0 bytes from an uninitialized pointer. While the memcpy() implementation will treat this as a no-op and not actually dereferece the undefined variable it is still undefined behaviour to the compiler and should be fixed. Found by building with clang HEAD Reviewed by: kp MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D52543 (cherry picked from commit 969be39fb3caf4272f128dbf3267ceba5966a6ce) --- sys/net/if_ovpn.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/net/if_ovpn.c b/sys/net/if_ovpn.c index 99c99369d22a..7c416055e939 100644 --- a/sys/net/if_ovpn.c +++ b/sys/net/if_ovpn.c @@ -914,9 +914,11 @@ ovpn_create_kkey_dir(struct ovpn_kkey_dir **kdirp, kdir->cipher = cipher; kdir->keylen = keylen; kdir->tx_seq = 1; - memcpy(kdir->key, key, keylen); + if (keylen != 0) + memcpy(kdir->key, key, keylen); kdir->noncelen = ivlen; - memcpy(kdir->nonce, iv, ivlen); + if (ivlen != 0) + memcpy(kdir->nonce, iv, ivlen); if (kdir->cipher != OVPN_CIPHER_ALG_NONE) { /* Crypto init */