From owner-svn-src-all@FreeBSD.ORG Sat Dec 12 19:46:16 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2AA74106568D for ; Sat, 12 Dec 2009 19:46:16 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id ACE9C8FC12 for ; Sat, 12 Dec 2009 19:46:15 +0000 (UTC) Received: (qmail 20936 invoked by uid 399); 12 Dec 2009 19:46:15 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 12 Dec 2009 19:46:15 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B23F30D.3020107@FreeBSD.org> Date: Sat, 12 Dec 2009 11:46:21 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20091206) MIME-Version: 1.0 To: Xin LI References: <200912112335.nBBNZdRT023731@svn.freebsd.org> In-Reply-To: <200912112335.nBBNZdRT023731@svn.freebsd.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r200420 - in head/usr.bin: ar c89 calendar cksum cmp colcrt colrm compress cpuset expand fetch file2c find finger fmt fold gcore getopt hexdump jot killall ktrace lastcomm limits lock l... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Dec 2009 19:46:16 -0000 Xin LI wrote: > Author: delphij > Date: Fri Dec 11 23:35:38 2009 > New Revision: 200420 > URL: http://svn.freebsd.org/changeset/base/200420 > > Log: > Remove unneeded header includes from usr.bin/ except contributed code. > > Tested with: make universe I don't want to "pile on" here but I am also curious about how the end results were tested. My understanding is that the traditional way to test these kinds of things is to checksum the binaries before and after the change to see if they are identical, and I was wondering if that was done here and if not why it is not necessary. That said, I'm certain that you must have put quite a lot of work into this and it must be difficult for you to hear so many questions after the fact. Rest assured that the effort you put into this IS appreciated. :) Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/