From owner-svn-src-all@freebsd.org Thu Jan 18 21:10:24 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2475EC3487; Thu, 18 Jan 2018 21:10:24 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8DEDA80FAE; Thu, 18 Jan 2018 21:10:24 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: by mail-wm0-f49.google.com with SMTP id g1so24517325wmg.2; Thu, 18 Jan 2018 13:10:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Iy4wE/2F+vV23CHQP3fhWQNqCPg2L+mHLs2K30lzxOE=; b=hJt0/VGcEXQN2G2GD9y8SNxMLQjcVhRLCUsyz2mgQN18mIDhB8RXzl+uBxW0wEFe2b aoMzs76mh0sr4QHmeryaZVU08vjnfNHLGITFIyxdVUYUOhVd+gPHlu1rp8ArX32fqVYv Ee22Wrm/1dkhiehG7EHxo4+4Bf0PbKcYp6AvEiN3EcTlTib3NQC6DhA9cE/T4ZGAxTWn 7oTiHYlVxr5MHHBLzigb8LLZPXOgryK3pboDh+BWEE7wjR7ExiE9uLoMK7HoyyxVVaEp xcAkPnnv1c/3XVQvq4HnbzQ4g9FQ76kklD/fTEGyozED8YSxo6BhPmIdPY4nlvTzsTnl 6LPw== X-Gm-Message-State: AKwxyte9LI+UmEtTuClZDhfEUDyWuV7kunLYY9CRRwzBvPE560dutKxG Rpr6iIliS3Wz8wJ+03/00aIBDfUI X-Google-Smtp-Source: ACJfBovHgUA5v1yJPCLfvsAnroFnocnKdiB6f3KMKWDi8x7+vLvs2w3tRrsbfxHzan2kkwSY8VJe/A== X-Received: by 10.80.211.7 with SMTP id g7mr9934644edh.76.1516309816412; Thu, 18 Jan 2018 13:10:16 -0800 (PST) Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id r12sm4864058edk.41.2018.01.18.13.10.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2018 13:10:16 -0800 (PST) Received: by mail-wr0-f177.google.com with SMTP id g38so20817660wrd.2; Thu, 18 Jan 2018 13:10:16 -0800 (PST) X-Received: by 10.223.161.29 with SMTP id o29mr7906063wro.2.1516309815746; Thu, 18 Jan 2018 13:10:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.176.48 with HTTP; Thu, 18 Jan 2018 13:10:15 -0800 (PST) In-Reply-To: References: <201712291905.vBTJ57gI072871@repo.freebsd.org> <20180117224054.GO8113@FreeBSD.org> <601ee1a2-8f4e-518d-4c86-89871cd652af@vangyzen.net> From: Matt Joras Date: Thu, 18 Jan 2018 13:10:15 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r327354 - head/sys/vm To: Warner Losh Cc: "Conrad E. Meyer" , Eric van Gyzen , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 21:10:25 -0000 On Thu, Jan 18, 2018 at 1:04 PM, Warner Losh wrote: > >> 1. Allowing local / block scoped variables >> 2. Allowing C99 for loop initial declarations >> >> But I could see the argument that (2) is just a boring subset of (1). > > > Tell me again where #1/#2 are disallowed? I can't seem to find that in > style(9), except by a weak example of there being no examples of #1 or #2. > > Warner > It is sort of implied by the sections stating the rules for declaring variables: "When declaring variables in functions declare them sorted by size, then n alphabetical order; multiple ones per line are okay." And this: "/* Insert an empty line if the function has no local variables. */" I don't see a more explicit note about them. Matt