From owner-svn-src-user@FreeBSD.ORG Wed Aug 24 07:28:05 2011 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DC311065673; Wed, 24 Aug 2011 07:28:05 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id EB97A8FC14; Wed, 24 Aug 2011 07:28:04 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p7O7S4L8038665; Wed, 24 Aug 2011 07:28:04 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p7O7S4bO038663; Wed, 24 Aug 2011 07:28:04 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201108240728.p7O7S4bO038663@svn.freebsd.org> From: Adrian Chadd Date: Wed, 24 Aug 2011 07:28:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r225133 - user/adrian/if_ath_tx/sys/dev/ath X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2011 07:28:08 -0000 Author: adrian Date: Wed Aug 24 07:28:04 2011 New Revision: 225133 URL: http://svn.freebsd.org/changeset/base/225133 Log: The descriptor + link is going to be updated anyway; so there's no need to copy the descriptors into the cloned buffer. Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Wed Aug 24 06:59:59 2011 (r225132) +++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c Wed Aug 24 07:28:04 2011 (r225133) @@ -1940,14 +1940,9 @@ ath_buf_clone(struct ath_softc *sc, cons /* NOTE: DMA segments will be setup by the setup/chain functions */ - /* - * Copy the descriptor contents - just the active - * number of segments. - */ - memcpy(tbf->bf_desc, bf->bf_desc, - bf->bf_nseg * sizeof(struct ath_desc)); + /* The caller has to re-init the descriptor + links */ - /* Copy status */ + /* Copy state */ memcpy(&tbf->bf_state, &bf->bf_state, sizeof(bf->bf_state)); return tbf;