From owner-p4-projects Mon Dec 2 16: 0:23 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id AA80537B404; Mon, 2 Dec 2002 16:00:21 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4278537B401 for ; Mon, 2 Dec 2002 16:00:21 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id C88BA43EB2 for ; Mon, 2 Dec 2002 16:00:17 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id A28372A8AB; Mon, 2 Dec 2002 16:00:17 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Marcel Moolenaar Cc: Doug Rabson , Perforce Change Reviews Subject: Re: PERFORCE change 21719 for review In-Reply-To: <20021202101553.GB6494@dhcp01.pn.xcllnt.net> Date: Mon, 02 Dec 2002 16:00:17 -0800 From: Peter Wemm Message-Id: <20021203000017.A28372A8AB@canning.wemm.org> Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Marcel Moolenaar wrote: > On Mon, Dec 02, 2002 at 09:58:30AM +0000, Doug Rabson wrote: > > > > I'm sorry - I thought that the thing was converted to bus_space when it > > grew all the non-isa bus attachments. This really needs to happen to > > make the driver portable. I'm not sure what to do with the > > isa_irq_pending call - probably migrate it to the isa attachment. > > I'm not sure. It really assumes PIC and doesn't really work with > APICs, due to it being a 32-bit bitmask. This is independent of > whether the device is on an ISA bus or not. I guess I don't have > an answer yet. int32 mask = isa_irq_pending() could be replaced with something like: bool pending = irq_pending(int irq); This can then be made to work on apic systems without too much work. But it is still wrong. :-) Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message