Date: Thu, 09 Mar 2017 00:56:49 +0100 From: "Carlos J. Puga Medina" <cpm@FreeBSD.org> To: Jan Beich <jbeich@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r435049 - in head/security/libgcrypt: . files Message-ID: <1489017409.3110.7.camel@FreeBSD.org> In-Reply-To: <20170308225120.1595A22D0@freefall.freebsd.org> References: <20170308225120.1595A22D0@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-7BJ3LINhLm80BDQPzVCh
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Hi Jan,
On Wed, 2017-03-08 at 22:51 +0000, Jan Beich wrote:
> "Carlos J. Puga Medina" <cpm@FreeBSD.org> writes:
>=20
> >=20
> > Modified: head/security/libgcrypt/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- head/security/libgcrypt/Makefile Tue Feb 28 12:06:09
> > 2017 (r435048)
> > +++ head/security/libgcrypt/Makefile Tue Feb 28 12:21:13
> > 2017 (r435049)
> > @@ -33,6 +33,10 @@ OPTIONS_DEFINE=3D DOCS
> > =C2=A0
> > =C2=A0.include <bsd.port.options.mk>
> > =C2=A0
> > +.if ${ARCH} =3D=3D "armv6" || ${ARCH} =3D=3D "aarch64"
> > +EXTRA_PATCHES+=3D ${FILESDIR}/extra-patch-aarch64
> > +.endif
> Why do you need aarch64-specific patch on armv6? I don't think
> FreeBSD
> runtime detection of SIMD features on armv6.
>=20
Definitely, you're right. I'll fix it.
> >=20
> > +
> > =C2=A0.if ${ARCH} =3D=3D "powerpc"
> > =C2=A0CONFIGURE_ARGS+=3D --disable-asm
> > =C2=A0.endif
> >=20
> > Added: head/security/libgcrypt/files/extra-patch-aarch64
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >=20
> > --- /dev/null 00:00:00 1970 (empty, because file is
> > newly added)
> > +++ head/security/libgcrypt/files/extra-patch-aarch64 Tue
> > Feb 28 12:21:13 2017 (r435049)
> > @@ -0,0 +1,68 @@
> > +--- cipher/cipher-gcm-armv8-aarch64-ce.S.orig 2016-11-12
> > 10:39:35 UTC
> > ++++ cipher/cipher-gcm-armv8-aarch64-ce.S
> > +@@ -23,7 +23,7 @@
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0defined(HAVE_COMPATIBLE_GCC_AARCH64_PLAT=
FORM_AS) && \
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0defined(HAVE_GCC_INLINE_ASM_AARCH64_CRYP=
TO)
> > +=C2=A0
> > +-.arch armv8-a+crypto
> > ++.cpu generic+simd+crypto
> Interesting. I've fixed a similar issue in r431494 via -no-
> integrated-as.
> 11.1 is going to have clang 4.0, so the workaround can be dropped 3
> months
> after release.
Libgcrypt 1.8 will be released in a few weeks and this patch is
included.
Regards,
--=20
Carlos Jacobo Puga Medina <cpm@FreeBSD.org>
PGP fingerprint =3D C60E 9497 5302 793B CC2D BB89 A1F3 5D66 E6D0 5453
--=-7BJ3LINhLm80BDQPzVCh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iQGTBAABCgB9FiEExg6Ul1MCeTvMLbuJofNdZubQVFMFAljAmkNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM2
MEU5NDk3NTMwMjc5M0JDQzJEQkI4OUExRjM1RDY2RTZEMDU0NTMACgkQofNdZubQ
VFMQEQf/XQgrN65nvTKfX14CsZJmY+uskbb6CALk/IsZ8EtiTw78tRWvlYqEHeSI
0mjwYwBEGv/DxOU8NLv4jbGHPmmUeIbGvu4FPsay/I0A9nvhaw1odO1+gKSIA7oh
rhCa9GmfNBh0LuRaQpsHKgYTPIWyRLEF5bngRsyZG96DJ6MhM+DHg6WhHz6fFiaP
Yao6bpx7py+7IdNTnH1h6WsJKFL8Z+Gqf+qSFl0y7N4RvGi2pzduLXQvoHcqWp8q
7RMF4m8Wu3jHRQEy+d+Mx92sRpX0drhjUQ6OoH7S8Jaw/mqpZyXgdRd9BtMQjDNL
XNtXNtfERt7JCFEhbO2YZKIinPmdPQ==
=7jch
-----END PGP SIGNATURE-----
--=-7BJ3LINhLm80BDQPzVCh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1489017409.3110.7.camel>