From owner-svn-ports-all@freebsd.org Fri Sep 9 06:29:56 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C57E8BD1476; Fri, 9 Sep 2016 06:29:56 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 69DD46EA; Fri, 9 Sep 2016 06:29:56 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 50D96BDC7F; Fri, 9 Sep 2016 08:29:53 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 242FDBDC79; Fri, 9 Sep 2016 08:29:53 +0200 (CEST) Subject: Re: svn commit: r421576 - in head/x11-wm/fluxbox: . files To: Alexey Dokuchaev , Jason Helfman References: <201609082007.u88K7Jhm001741@repo.freebsd.org> <20160909044034.GA62060@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: Date: Fri, 9 Sep 2016 08:29:50 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160909044034.GA62060@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2Co9tmFxojxJrIJpxxCrOc9W4LEkBgcR8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 06:29:56 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Co9tmFxojxJrIJpxxCrOc9W4LEkBgcR8 Content-Type: multipart/mixed; boundary="uwKKHX6AR40mDJ47C28PAHEwDR43o7Adl"; protected-headers="v1" From: Mathieu Arnold To: Alexey Dokuchaev , Jason Helfman Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r421576 - in head/x11-wm/fluxbox: . files References: <201609082007.u88K7Jhm001741@repo.freebsd.org> <20160909044034.GA62060@FreeBSD.org> In-Reply-To: <20160909044034.GA62060@FreeBSD.org> --uwKKHX6AR40mDJ47C28PAHEwDR43o7Adl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 09/09/2016 =C3=A0 06:40, Alexey Dokuchaev a =C3=A9crit : > On Thu, Sep 08, 2016 at 08:07:19PM +0000, Jason Helfman wrote: >> New Revision: 421576 >> URL: https://svnweb.freebsd.org/changeset/ports/421576 >> >> [...] >> -PORTDOCS=3D AUTHORS ChangeLog NEWS README TODO >> +PORTDATA=3D * >> +PORTDOCS=3D * >> ... >> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_active.xpm >> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_pressed.xpm >> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_unfocus.xpm >> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_max_active.xpm >> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_max_pressed.xpm >> ... > Please don't do this. We should had never allowed globbed PORTDATA (it= is > less of an issue for PORTDOCS since they are usually less important and= > interesting). > > We have pkg-plist for a reason. It helps to track changes, assess them= > against the changelog, compare pkg-plists of different versions, etc. > > Previously I could see a new theme/style files in the commit diff and > think, "hey, I should try that new version, wanna see it that theme loo= ks > nicer than my current one". Now it becomes harder. As a side note, I plan on deprecating the PORTDATA macro soon for that exact reason. --=20 Mathieu Arnold --uwKKHX6AR40mDJ47C28PAHEwDR43o7Adl-- --2Co9tmFxojxJrIJpxxCrOc9W4LEkBgcR8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJX0lbfXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I1IUP/31P5gtQw2qg1i47JFWqGlrP gxL4AltBssXyIPag3kfwZkCfuR3ONUMqe8mmKStaulJokqdKcLFKaA6+QiTYCNNm wJPN2kC13g4Xqn1twJmm0km3AMmszrtasjOg1WnDFitsRIuhvozujpPz+Xh+PrEh mDv7Tjuc4YDGCRi091r7vln98ibsMKKHhO37GsztSI9OsDWKgt6VrQ867KKUI3mP igbSUP4VaWH+Jo9elb5oDZo2TLd0bQQ4vYQk+yvbKRIB4/tvkwR8whonDicpXfd3 +MWtnK2dREZKWvCbm6kTaLyXD+2cun7vKgZZUzsU50BFQQgCqW2JiUkO5rnEI3bK t/QodhLPvR7YywJZLouP2NdiQrYPMu5Gx5xwh+L8ToqvWvUUbLU12VH1rYuVuVdu TLGmtI9ye1gYIyuk7dGzwL/7hndaXcB3imsChypPrSzfkqm9AQnLJkNa6qqCS/1I /P9BkbsXaVbGPQShfpEr5/lwkz7aFjEOx30m4LRJnyiqzDCapxrvBZkrpUxFEr5X hpzktK91e3N43oNbAN8noM8Han2uG2k3dRe+KTTUOlNL3BdlYF3QpfX6rIBmrK/U mLPDzMadZXOVQOjej62B70qbg40/oL5lcyxlCKlwtpbjEzg0oFe6ouV62ZpUt6Ns biitMQnlZif7w5uu8Tbi =V523 -----END PGP SIGNATURE----- --2Co9tmFxojxJrIJpxxCrOc9W4LEkBgcR8--