From owner-p4-projects  Mon Apr  1 11:45:46 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0936337B417; Mon,  1 Apr 2002 11:45:37 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mail12.speakeasy.net (mail12.speakeasy.net [216.254.0.212])
	by hub.freebsd.org (Postfix) with ESMTP id EB51537B400
	for <perforce@freebsd.org>; Mon,  1 Apr 2002 11:45:35 -0800 (PST)
Received: (qmail 6966 invoked from network); 1 Apr 2002 19:45:35 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender <jhb@FreeBSD.org>)
          by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <perforce@freebsd.org>; 1 Apr 2002 19:45:35 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g31JkIv15385;
	Mon, 1 Apr 2002 14:46:18 -0500 (EST)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020401144535.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <Pine.BSF.4.21.0204011115520.15571-100000@InterJet.elischer.org>
Date: Mon, 01 Apr 2002 14:45:35 -0500 (EST)
From: John Baldwin <jhb@FreeBSD.org>
To: Julian Elischer <julian@elischer.org>
Subject: Re: PERFORCE change 8807 for review
Cc: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG


On 01-Apr-2002 Julian Elischer wrote:
> I ansify every declaration I come across....

Well, to be honest, those should be done separate from code commits. :)  Also,
most of this file still uses K&R.  I probably should do a sweep of the file
prior to committing to fixup all the declarations, but doing so would probably
trigger some flamewar or another over it. :)

> On Mon, 1 Apr 2002, John Baldwin wrote:
> 
>> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=8807
>> 
>> Change 8807 by jhb@jhb_laptop on 2002/04/01 11:11:59
>> 
>>      Bah, K&R function declarations suck. :)  I missed removing the flag
>>      argument the second time.  Bite the bullet and just use ANSI
>>      declarations for suser() and suser_cred().
>> 
>> Affected files ...
>> 
>> ... //depot/projects/smpng/sys/kern/kern_prot.c#53 edit
>> 
>> Differences ...
>> 
>> ==== //depot/projects/smpng/sys/kern/kern_prot.c#53 (text+ko) ====
>> 
>> @@ -1265,9 +1265,7 @@
>>   * specify jail interaction.
>>   */
>>  int
>> -suser_cred(cred, flag)
>> -    struct ucred *cred;
>> -    int flag;
>> +suser_cred(struct ucred *cred, int flag)
>>  {
>>  
>>      if (!suser_enabled)
>> @@ -1284,9 +1282,7 @@
>>   * caller, promoting binary compatibility.
>>   */
>>  int
>> -suser(td)
>> -    struct thread *td;
>> -    int flag;
>> +suser(struct thread *td)
>>  {
>>  
>>      return (suser_cred(td->td_ucred, 0));
>> 
> 

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message