From owner-svn-ports-all@FreeBSD.ORG  Thu Jul 11 13:09:03 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id B60E7E67; Thu, 11 Jul 2013 13:09:03 +0000 (UTC)
Date: Thu, 11 Jul 2013 13:09:03 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: William Grzybowski <william88@gmail.com>
Subject: Re: svn commit: r322724 - head/net-p2p/qbittorrent
Message-ID: <20130711130903.GC72196@FreeBSD.org>
References: <201307101754.r6AHshZl027414@svn.freebsd.org>
 <20130711054533.GA70334@FreeBSD.org>
 <CAHtVNLPCmTBpC2uvaYdR2+1qQpCgr2UqUmgycF9Qdg4oBgNMVA@mail.gmail.com>
 <20130711125532.GA72196@FreeBSD.org>
 <CAHtVNLMJ7CzNC6X+eO6g8=qp9zvCoEwM9iXMPRm9-WTS75TYPQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHtVNLMJ7CzNC6X+eO6g8=qp9zvCoEwM9iXMPRm9-WTS75TYPQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 William Grzybowski <wg@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jul 2013 13:09:03 -0000

On Thu, Jul 11, 2013 at 10:03:05AM -0300, William Grzybowski wrote:
> On Thu, Jul 11, 2013 at 9:55 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > On Thu, Jul 11, 2013 at 08:42:23AM -0300, William Grzybowski wrote:
> >> On Thu, Jul 11, 2013 at 2:45 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> >> > On Wed, Jul 10, 2013 at 05:54:43PM +0000, William Grzybowski wrote:
> >> >> New Revision: 322724
> >> >> URL: http://svnweb.freebsd.org/changeset/ports/322724
> >> >>
> >> >> @@ -43,7 +46,7 @@ CONFIGURE_ARGS+=    --disable-qt-dbus
> >> >>  .endif
> >> >>
> >> >>  post-patch:
> >> >> -     @${REINPLACE_CMD} -e 's,qputenv,!&,' ${WRKSRC}/src/main.cpp
> >> >> +     @${REINPLACE_CMD} -e 's|qputenv|!&|' ${WRKSRC}/src/main.cpp
> >> >
> >> > There are two problems with this part:
> >> > [...]
> >>
> >> It would make everyones life easier if you had put a comment in the
> >> post-patch line about that fact.
> >
> > True; usually I document any REINPLACE_CMD which might be confusing to
> > others, in this case I thought it's kinda self-explanatory.  The point
> > is that 1) many porters/comitters do not document these things, and it
> > might happen to anyone else; 2) regardless of the presence of comment,
> > or lack thereof, anyone who is updating the port should recheck if any
> > previous patch(es) are still valid.  This was obviously not done here.
> 
> Point taken, twice, and I appreciate your comments, I screwed up.
> How long should I knee in grains of corn? ;)

William, :)

Man, sorry if I didn't make it clear; I was mainly not targeting you,
but new maintainer (the last paragraph of my first mail suggests it).

./danfe