From owner-cvs-all@FreeBSD.ORG Sun Jun 15 14:45:44 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B03637B401; Sun, 15 Jun 2003 14:45:44 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB77743F75; Sun, 15 Jun 2003 14:45:43 -0700 (PDT) (envelope-from wpaul@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h5FLjh0U082084; Sun, 15 Jun 2003 14:45:43 -0700 (PDT) (envelope-from wpaul@repoman.freebsd.org) Received: (from wpaul@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h5FLjhdD082083; Sun, 15 Jun 2003 14:45:43 -0700 (PDT) Message-Id: <200306152145.h5FLjhdD082083@repoman.freebsd.org> From: Bill Paul Date: Sun, 15 Jun 2003 14:45:43 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/usb if_axe.c if_axereg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jun 2003 21:45:44 -0000 wpaul 2003/06/15 14:45:43 PDT FreeBSD src repository Modified files: sys/dev/usb if_axe.c if_axereg.h Log: In the device attach routine, don't depend on uaa->iface being populated. Apparently, if you use an ehci controller, it's not. Use usbd_device2interface_handle() to retrieve the interface handle. NOTE: uaa->iface is populated in the probe routine, so I suspect the fact that it's NULL in the attach routine is a bug in the ehci driver. Also, don't depend on the PHY addresses returned by the AXE_CMD_READ_PHYID command. The address is correct for my LinkSys NIC, but a user has reported that with a D-Link NIC, the PHYID command returns address 4 while the attached Broadcom PHY is in fact strapped for address 0. Instead, latch onto the first PHY address that returns valid data during a readreg operation. Revision Changes Path 1.4 +23 -4 src/sys/dev/usb/if_axe.c 1.2 +1 -0 src/sys/dev/usb/if_axereg.h