From owner-freebsd-ports  Tue Aug 19 15:38:36 1997
Return-Path: <owner-freebsd-ports>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id PAA10668
          for ports-outgoing; Tue, 19 Aug 1997 15:38:36 -0700 (PDT)
Received: from sumatra.americantv.com (sumatra.americantv.com [207.170.17.37])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id PAA10660;
          Tue, 19 Aug 1997 15:38:26 -0700 (PDT)
Received: from right.PCS (right.PCS [148.105.10.31])
	by sumatra.americantv.com (8.8.5/8.8.5) with ESMTP id RAA21885;
	Tue, 19 Aug 1997 17:56:13 -0500 (CDT)
Received: (jlemon@localhost) by right.PCS (8.6.13/8.6.4) id RAA17256; Tue, 19 Aug 1997 17:39:40 -0500
Message-ID: <19970819173939.43163@right.PCS>
Date: Tue, 19 Aug 1997 17:39:39 -0500
From: Jonathan Lemon <jlemon@americantv.com>
To: Jaye Mathisen <mrcpu@cdsnet.net>
Cc: hackers@FreeBSD.ORG, ports@FreeBSD.ORG
Subject: Re: vm86.h compile warning
References: <Pine.NEB.3.95.970819141906.17998E-100000@mail.cdsnet.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.61.1
In-Reply-To: <Pine.NEB.3.95.970819141906.17998E-100000@mail.cdsnet.net>; from Jaye Mathisen on Aug 08, 1997 at 02:20:28PM -0700
Sender: owner-freebsd-ports@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Aug 08, 1997 at 02:20:28PM -0700, Jaye Mathisen wrote:
> 
> I have no idea if this warning is apropos to this header file or not, and
> I wouldn't deign to guess at it's correctness.
> 
> I just point it out because I don't like warnings that tell me I'm
> probably not getting what I bargained for. :)
> 
> Build of skill-3.7.4 on -current:
> 
> ===>  Configuring for skill-3.7.4
> Configuring as bsd44: OSTYPE=bsd-44 COPTS= LIBS=-lkvm
> ===>  Building for skill-3.7.4
> cc -O  -c main.c
> cc -O  -c argparse.c
> rm -f getproc.c getproc.o
> ln -s machdep/bsd-44.c getproc.c
> cc -O  -c getproc.c
> In file included from /usr/include/machine/pcb_ext.h:36,
>                  from /usr/include/machine/pcb.h:48,
>                  from /usr/include/sys/user.h:40,
>                  from getproc.c:22:
> /usr/include/machine/vm86.h:109: warning: `struct proc' declared inside
> parameter list
> /usr/include/machine/vm86.h:109: warning: its scope is only this
> definition or declaration,
> /usr/include/machine/vm86.h:109: warning: which is probably not what you
> want.
> cc -O  main.o argparse.o getproc.o -o skill -lkvm

Ugh.  <machine/vm86.h> declares a function that takes a (struct proc *)
as a parameter, but you haven't included <sys/proc.h> beforehand, so
thus this error.  I see that <sys/user.h> does pull in proc.h, but too
late.

I'm not sure what the best way to fix this is; #ifdef KERNEL around the
parameter declarations in vm86.h?
--
Jonathan