From nobody Fri Aug 11 02:13:24 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RMS503TYtz4TvdG; Fri, 11 Aug 2023 02:13:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RMS502pY8z4JLb; Fri, 11 Aug 2023 02:13:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691720004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HWhycCxDIQSrL9awwjaL1VedaJo75OrvyYmqlOopWRc=; b=vCAs4eob4GNDqxie35Wt/wJZD5VO0jY3Qn/b2zybCfXzGnvY4v9wbFc3um0mE5YCyFWLM9 Z1LKNgVTNjlcznQdZwXeytjFV3K6sx9M9q/g/ySCQXEi9Ug8OOJpDylYXFaIjM1ajbtCmW 8LgM9d/wD/yQoSWf3VJILjV0VQit8QR7dj4/C6CHRpxIX1bV0Unl7l2HkNfpCDvXpTxV0j deZPRieFR4x8rNBY8NFD/t2G1KP2z7JriOCwChnZJ3lmVAxMtiFexVNuWwKf21h8oKriQG Hc6W0eOriFg1Ai9/HiVgeTaBp9bITH7kc0CuNt7CgWi+KhhcI91ABE1PUfd6tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1691720004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HWhycCxDIQSrL9awwjaL1VedaJo75OrvyYmqlOopWRc=; b=uHQDeK+oc791DnB4Nvw1H0FqXxKmVrkIJG3z2nY9VO+n4uVcsZKp4DDQA3HrZviLj0Y1KP D47fOp1VgkMG7+uDMIc6k94hdn/tlirD1k+e/K6yezpZGLmVJSnHjsYqc2zzw5cXb9xfaX fzRVepZdPvz4qnCwRxuRGZKkq7aZ6yhHrUBLqhA7WMt9d6FYujv7kfsEyxXww/FmtePTSM 6kSSyhj0lqbvEcc+P7342LMz5kTgU75599epmJuDrEJ+lbE99d6J8hv1FmJLRtbxght5Ef 1pog8/w4LY/8fimJ9arZs8qiv9hDJr1oI8Xv4aRMFubg+TGw4Vn/MsYsJHKt1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1691720004; a=rsa-sha256; cv=none; b=eClabeALS4hgOWLi6Gi94Y1GLNkppEyH7IH6yTXZmxprHs/9gn8prGoMzMq2KUCruvWpwk +5vBlYLxNwvFD2zTlf0EQqpB6zsySssCs3y1hKzrEXuHOL9MnYKR18aoon4HqvtmX1236H jQsKn6UeT2qb/4JGj9UnqIl+l36s52C1JLZYMtIwrb1g7Ro4vUWuui0kXnxKsZziOY0VNH PgE/IGTH8j5bqUJTLVzFceFuYFx3YmZ5p3W+yOC4FlpKuetE2urCtmmuixWd9YVskuMem7 9grG2HSjavEJYRVnAavMWA7yyy/IRXALx/Ve9GfT8Lfa6lX9+gWihWexcJTtFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RMS501cDJz61q; Fri, 11 Aug 2023 02:13:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 37B2DOtA008643; Fri, 11 Aug 2023 02:13:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 37B2DOWB008640; Fri, 11 Aug 2023 02:13:24 GMT (envelope-from git) Date: Fri, 11 Aug 2023 02:13:24 GMT Message-Id: <202308110213.37B2DOWB008640@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: bfed2417f472 - main - qcom: fix panic in qcom_mdio_ipq4018 implementation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bfed2417f472f87e720b37bdac9ffd75ca2abc54 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=bfed2417f472f87e720b37bdac9ffd75ca2abc54 commit bfed2417f472f87e720b37bdac9ffd75ca2abc54 Author: Bjoern A. Zeeb AuthorDate: 2023-08-11 02:05:45 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-08-11 02:12:55 +0000 qcom: fix panic in qcom_mdio_ipq4018 implementation Fix a boot-time panic in qcom_mdio_ipq4018 due to a missing bus function and hook the file up to the build so that it will not rot away. Test booted on an ipq807x in 2022. X-Differential Revision: extracted from D37882 --- sys/arm64/conf/std.qcom | 1 + sys/conf/files.arm64 | 1 + sys/dev/qcom_mdio/qcom_mdio_ipq4018.c | 3 +++ 3 files changed, 5 insertions(+) diff --git a/sys/arm64/conf/std.qcom b/sys/arm64/conf/std.qcom index 4bac8ab83dca..af7e0add8b40 100644 --- a/sys/arm64/conf/std.qcom +++ b/sys/arm64/conf/std.qcom @@ -4,6 +4,7 @@ # Qualcomm Snapdragon drivers device qcom_gcc # Global Clock Controller +device qcom_mdio # MDIO support # Serial (COM) ports device uart_msm # Qualcomm MSM UART driver diff --git a/sys/conf/files.arm64 b/sys/conf/files.arm64 index 31c296d49d86..29d805dd64b7 100644 --- a/sys/conf/files.arm64 +++ b/sys/conf/files.arm64 @@ -643,6 +643,7 @@ dev/flash/flexspi/flex_spi.c optional clk flex_spi soc_nxp_ls fdt # Qualcomm arm64/qualcomm/qcom_gcc.c optional qcom_gcc fdt +dev/qcom_mdio/qcom_mdio_ipq4018.c optional qcom_mdio fdt mdio mii # RockChip Drivers arm64/rockchip/rk3328_codec.c optional fdt rk3328codec soc_rockchip_rk3328 diff --git a/sys/dev/qcom_mdio/qcom_mdio_ipq4018.c b/sys/dev/qcom_mdio/qcom_mdio_ipq4018.c index 5045a8d440f8..8e4a28c5984f 100644 --- a/sys/dev/qcom_mdio/qcom_mdio_ipq4018.c +++ b/sys/dev/qcom_mdio/qcom_mdio_ipq4018.c @@ -273,6 +273,9 @@ static device_method_t qcom_mdio_ipq4018_methods[] = { DEVMETHOD(device_attach, qcom_mdio_ipq4018_attach), DEVMETHOD(device_detach, qcom_mdio_ipq4018_detach), + /* Bus interface */ + DEVMETHOD(bus_add_child, bus_generic_add_child), + /* MDIO interface */ DEVMETHOD(mdio_readreg, qcom_mdio_ipq4018_readreg), DEVMETHOD(mdio_writereg, qcom_mdio_ipq4018_writereg),