From owner-cvs-src@FreeBSD.ORG Mon Dec 17 07:13:21 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 45CF816A417 for ; Mon, 17 Dec 2007 07:13:21 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.176]) by mx1.freebsd.org (Postfix) with ESMTP id 0FAF513C455 for ; Mon, 17 Dec 2007 07:13:20 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so3329427waf.3 for ; Sun, 16 Dec 2007 23:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=WDuWAPgirTcxrUBjwL5kdY3uiLTz2TZ7fnJA0PZXhuk=; b=VASh849xBGeKY8th2hyHpTu0cny/Ci0idisL788ooDAC2ciz9ygTrheUyHfsMdPljVRcRQ389TfvriVBEVlHrNWtA00E2w0EETgpLP3bc893o6v/Kgp4VN7yRWouma+mITPiAKkb6gmTW2tX6XbtFhr8bQ2V6dBGL1glVY6vkwM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jcYoRVl8ofB93wztMFJ96j31VpQHBwtb4PswR9t4mdGuvRsRx+1pSwAUQ4Jisuo4wJARaWoADrQSEbzQdnrDOc+7GVttb7b52mRW/HgOx//pdkx4fhZWQktC/FEAkkZ8MF9LoyMNbpq50+IpsmYa+FST3rx2o8Oeo2KQfegpAzg= Received: by 10.115.58.1 with SMTP id l1mr2185070wak.110.1197875600054; Sun, 16 Dec 2007 23:13:20 -0800 (PST) Received: by 10.114.255.11 with HTTP; Sun, 16 Dec 2007 23:13:20 -0800 (PST) Message-ID: Date: Sun, 16 Dec 2007 23:13:20 -0800 From: "Kip Macy" To: "Sam Leffler" In-Reply-To: <47660A57.8060108@errno.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200712170419.lBH4JPJg026761@repoman.freebsd.org> <47660A57.8060108@errno.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Kip Macy , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet if_ether.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2007 07:13:21 -0000 On Dec 16, 2007 9:34 PM, Sam Leffler wrote: > Kip Macy wrote: > > kmacy 2007-12-17 04:19:25 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet if_ether.c > > Log: > > Don't panic in arpresolve if we're given a null mbuf. We could > > insist that the caller just pass in an initialized mbuf even > > if didn't have any data - but that seems rather contrived. > > > > You don't explain the purpose of this change. arpresolve has been > designed for use in the xmit path where there is always an mbuf. This > feels like you are now applying it for a different purpose and it might > be better to define a different api than overload arpresolve's intended > purpose. I will do that. I did it this way because adding an interface felt redundant as I basically need the exact same functionality without the mbuf checks. -Kip