Date: Mon, 4 Mar 2013 15:50:01 +0000 From: Chris Rees <utisoft@gmail.com> To: Eitan Adler <lists@eitanadler.com> Cc: ports@freebsd.org Subject: Re: Using RUN_DEPENDS := ${BUILD_DEPENDS} is now a bug Message-ID: <CADLo8388f-W-T4nMr6RzhrZmJZwFp5Nig0ouztS%2B9Q4NnFXEaw@mail.gmail.com> In-Reply-To: <CAF6rxgmH9QJ2qYPT17W=nVUU2pYTfGmBBBwMDiQPA8SAj1tJuw@mail.gmail.com> References: <CAF6rxgmH9QJ2qYPT17W=nVUU2pYTfGmBBBwMDiQPA8SAj1tJuw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4 Mar 2013 01:38, "Eitan Adler" <lists@eitanadler.com> wrote: > > Some time ago ("2012-01-21 17:40:15 UTC") I committed a change which > converted all uses of > > BUILD_DEPENDS= ${RUN_DEPENDS} > to > BUILD_DEPENDS:= ${RUN_DEPENDS} > > Writing: > > ==== > At the moment 1385 ports use BUILD_DEPENDS= ${RUN_DEPENDS} and 450 > ports use BUILD_DEPENDS:= ${RUN_DEPENDS}. This patch fixes ports that are > currently broken. This is a temporary measure until we organically stop using > := or someone(s) spend a lot of time changing all the ports over. > > Explicit duplication > := > = and this just moves ports one step to the left > ==== > > With the introduction of devel/ccache support this is now a more critical issue: > > ports that use BUILD_DEPENDS:= ${RUN_DEPENDS} are buggy. > > Set WITH_CCACHE_BUILD=yes in /etc/make.conf and observe > > [10046 eitan@gravity (100)% ...n/fbsd/ports/editors/led ]%make run-depends-list > /usr/ports/lang/perl5.14 > [10047 eitan@gravity (100)% ...n/fbsd/ports/editors/led ]%vim Makefile > # add "RUN_DEPENDS := ${BUILD_DEPENDS} > [10048 eitan@gravity (100)% ...n/fbsd/ports/editors/led ]%make run-depends-list > /usr/ports/devel/ccache > /usr/ports/lang/perl5.14 > > Ports should *not* assume that BUILD_DEPENDS is clear when initiated > and ports should explicitly duplicate RUN_DEPENDS. Why not? When is ccache added to BUILD_DEPENDS? I guess I just don't see how this can happen. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo8388f-W-T4nMr6RzhrZmJZwFp5Nig0ouztS%2B9Q4NnFXEaw>