From owner-cvs-all@FreeBSD.ORG Fri Jul 14 15:31:51 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1934216A4DF; Fri, 14 Jul 2006 15:31:51 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB21943D49; Fri, 14 Jul 2006 15:31:50 +0000 (GMT) (envelope-from ehaupt@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6EFVoRE000311; Fri, 14 Jul 2006 15:31:50 GMT (envelope-from ehaupt@repoman.freebsd.org) Received: (from ehaupt@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6EFVou0000310; Fri, 14 Jul 2006 15:31:50 GMT (envelope-from ehaupt) Message-Id: <200607141531.k6EFVou0000310@repoman.freebsd.org> From: Emanuel Haupt Date: Fri, 14 Jul 2006 15:31:50 +0000 (UTC) To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: ports/graphics/xv Makefile ports/graphics/xv/files patch-xvxwd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2006 15:31:51 -0000 ehaupt 2006-07-14 15:31:50 UTC FreeBSD ports repository Modified files: graphics/xv Makefile Added files: graphics/xv/files patch-xvxwd.c Log: With 24/32-bit xwd files, xv swaps the red and blue channels. With 16-bit xwd files, the image is very dark green (almost black). Both problems are caused by hard-coding the channel order and offsets, rather than using the colour masks in the xwd header. xv reads the input into a 24-bit internal image, which is then displayed. The lack of brightness in the 16-bit display is because the colour values are copied into the low-order bits of the internal pixmap rather than the high order bits. The green hue is because the green channel has 6 bits, whereas red and blue only have 5 bits, making the green twice as (relatively) bright. The new patch solves that problem. PR: 96971 Submitted by: Peter Jeremy Approved by: Miguel Mendez (maintainer) Revision Changes Path 1.65 +1 -1 ports/graphics/xv/Makefile 1.1 +171 -0 ports/graphics/xv/files/patch-xvxwd.c (new)