From owner-svn-src-all@freebsd.org Wed Feb 27 21:43:57 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C613F150603C; Wed, 27 Feb 2019 21:43:57 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6B8B591421; Wed, 27 Feb 2019 21:43:57 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from cerise.vangyzen.net (unknown [70.97.188.230]) by smtp.vangyzen.net (Postfix) with ESMTPSA id CB7E056468; Wed, 27 Feb 2019 15:43:48 -0600 (CST) From: Eric van Gyzen Message-Id: <93571A02-D75D-47AB-981F-5312D4B6BEDD@vangyzen.net> Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec Date: Wed, 27 Feb 2019 15:43:47 -0600 In-Reply-To: Cc: Alexey Dokuchaev , "Rodney W. Grimes" , "Simon J. Gerraty" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org To: Warner Losh References: <201902260617.x1Q6HOra098699@repo.freebsd.org> <201902260619.x1Q6Jjn2043418@pdx.rh.CN85.dnsmgr.net> <20190226134953.GB39566@FreeBSD.org> X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 6B8B591421 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.991,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 21:43:58 -0000 > On Feb 26, 2019, at 10:17 PM, Warner Losh wrote: >=20 >=20 >=20 > On Tue, Feb 26, 2019, 6:50 AM Alexey Dokuchaev > wrote: > On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote: > > > Author: sjg > > > Date: Tue Feb 26 06:17:23 2019 > > > New Revision: 344567 > > > URL: https://svnweb.freebsd.org/changeset/base/344567 = > > >=20 > > > Log: > > > Add verifying manifest loader for mac_veriexec > > > =20 > > > This tool will verify a signed manifest and load contents into > > > mac_veriexec for storage > > > =20 > > > Sponsored by: Juniper Networks > > > Differential Revision: D16575 > >=20 > > Just a small nit, for future reference, from the template: > > > Differential Revision: https://reviews.freebsd.org/D### = > > (*full* phabric URL needed). >=20 > IMHO we should just fix the scripts to accept D#### alone, without > the URL. We don't do that for PR (bugzilla) references, and the fact > that we do for the phab is both needless and confusing. Also, that > URL might change one day while we could probably keep the old numbers > if we move. >=20 > When this came up before, it was an upstream decision to require the = full path. The reasoning is that Dxxxx space isn't unique and the review = may happen in a different instance of phab than the default one. When = those exact objections were raised, the experience of moving to bugzilla = was cited to show the URL can remain stable. And if we went to another = system's, we could keep the old in place and then we would need a new = URL to disambiguate. There were good reasons we decided this before. >=20 > So this has been litigated before, and the consensus was we needed to = break with the practice of not putting URLs in commit messages for these = reasons. I completely agree. In fact, I=E2=80=99d like to see full bugzilla URLs = in commit logs instead of just the bug number. Every app I use to read = commit logs will make URLs clickable, even my terminal emulator. The = fact that I have to manually open bugzilla and copy/type the bug number = is annoying. And yes, I volunteer to make the necessary changes to accept URLs in the = PR field. We just need consensus. Eric=