From owner-p4-projects@FreeBSD.ORG Wed Aug 25 19:28:06 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9977410656A7; Wed, 25 Aug 2010 19:28:06 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B9251065694; Wed, 25 Aug 2010 19:28:06 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from swip.net (mailfe05.swip.net [212.247.154.129]) by mx1.freebsd.org (Postfix) with ESMTP id A9B448FC15; Wed, 25 Aug 2010 19:28:05 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=sIybwy0z7bWw0ilx/SziPN3xnsQN4yn8NMXKZM3k7p4= c=1 sm=1 a=ERo4XiVTCLMA:10 a=8nJEP1OIZ-IA:10 a=M8b_wTzEtboA:10 a=MnI1ikcADjEx7bvsp0jZvQ==:17 a=6I5d2MoRAAAA:8 a=xNf9USuDAAAA:8 a=XUorp9ACwTL8auJ8axcA:9 a=L-EdpAYFUWLlLPH4FKMA:7 a=fJ2L642aUhUfEysqy4mb6Pwr7p8A:4 a=wPNLvfGTeEIA:10 a=SV7veod9ZcQA:10 a=MnI1ikcADjEx7bvsp0jZvQ==:117 Received: from [188.126.201.140] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe05.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 11057869; Wed, 25 Aug 2010 21:18:01 +0200 Received-SPF: softfail receiver=mailfe05.swip.net; client-ip=188.126.201.140; envelope-from=hselasky@freebsd.org From: Hans Petter Selasky To: Garrett Cooper Date: Wed, 25 Aug 2010 21:14:05 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.1-STABLE; KDE/4.4.5; amd64; ; ) References: <201008251649.o7PGnD8q074706@skunkworks.freebsd.org> In-Reply-To: X-Face: +~\`s("[*|O,="7?X@L.elg*F"OA\I/3%^p8g?ab%RN'( =?iso-8859-1?q?=3B=5FIjlA=3A=0A=09hGE=2E=2EEw?=, =?iso-8859-1?q?XAQ*o=23=5C/M=7ESC=3DS1-f9=7BEzRfT=27=7CHhll5Q=5Dha5Bt-s=7Co?= =?iso-8859-1?q?TlKMusi=3A1e=5BwJl=7Dkd=7DGR=0A=09Z0adGx-x=5F0zGbZj=27e?=(Y[(UNle~)8CQWXW@:DX+9)_YlB[tIccCPN$7/L' MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008252114.05428.hselasky@freebsd.org> Cc: Perforce Change Reviews Subject: Re: PERFORCE change 182898 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2010 19:28:06 -0000 On Wednesday 25 August 2010 20:21:25 Garrett Cooper wrote: > On Wed, Aug 25, 2010 at 9:49 AM, Hans Petter Selasky > > wrote: > > http://p4web.freebsd.org/@@182898?ac=10 > > > > Change 182898 by hselasky@hselasky_laptop001 on 2010/08/25 16:49:00 > > > > LibUSB: > > - patch for GNU/kFreeBSD by David Moles > > > > PR: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594330 Reviewed by: > > hselasky @ > > > > Affected files ... > > > > .. //depot/projects/usb/src/lib/libusb/libusb20.c#19 edit > > > > Differences ... > > > > ==== //depot/projects/usb/src/lib/libusb/libusb20.c#19 (text+ko) ==== > > > > @@ -1182,7 +1182,7 @@ > > { > > struct libusb20_backend *pbe; > > > > -#ifdef __FreeBSD__ > > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > > pbe = libusb20_be_alloc(&libusb20_ugen20_backend); > > #else > > pbe = NULL; > > Crazy question... if GNU/kFreeBSD is going to be rebranding the kernel > as __FreeBSD_kernel__, what about the rest of the references that are > guarded by __FreeBSD__ ? > Thanks, > -Garrett This check is not for checking if we are compiling in the kernel or not. It is only to check if we have a FreeBSD system kernel or not when compiling in userspace. Fortunately LibUSB only has one of these checks. Was that your question? --HPS