From owner-freebsd-bugs@FreeBSD.ORG  Sun Jun  8 14:35:23 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E14D1FE0
 for <freebsd-bugs@FreeBSD.org>; Sun,  8 Jun 2014 14:35:23 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C8C582A4C
 for <freebsd-bugs@FreeBSD.org>; Sun,  8 Jun 2014 14:35:23 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s58EZNB0032614
 for <freebsd-bugs@FreeBSD.org>; Sun, 8 Jun 2014 15:35:23 +0100 (BST)
 (envelope-from bz-noreply@freebsd.org)
From: bz-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 190793] New: Some rc scripts return non zero status on success
Date: Sun, 08 Jun 2014 14:35:23 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: conf
X-Bugzilla-Version: 10.0-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: belzebubc@gmail.com
X-Bugzilla-Status: Needs Triage
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 attachments.created
Message-ID: <bug-190793-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Jun 2014 14:35:24 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190793

            Bug ID: 190793
           Summary: Some rc scripts return non zero status on success
           Product: Base System
           Version: 10.0-STABLE
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Some People
          Priority: ---
         Component: conf
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: belzebubc@gmail.com

Created attachment 143528
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=143528&action=edit
remove "[ foo ] && bar" hack

Rc scripts (/etc/rc.d/*) is written to return status returned by the last
executed command. This is correct behavior, but it cause problems with
construction like this:

[ -n "${foo}" ] && echo '.'

This construction may return 1 and if it is the last command, whole script
return 1. This behavior was certainly not intended, I guess. So construction
above should  be changed into correcrt form:

if [ -n "${foo}" ]; then
   echo '.'
fi

I find this bug in /etc/rc.d/routing, but more scripts are affected. Situation
when bug appear depends on configuration of services. Patch removing this hack
from all scripts is attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.