From owner-freebsd-bugs@FreeBSD.ORG Sun Feb 1 11:00:18 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1075D1065670 for ; Sun, 1 Feb 2009 11:00:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C61018FC27 for ; Sun, 1 Feb 2009 11:00:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n11B0Hxx037288 for ; Sun, 1 Feb 2009 11:00:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n11B0HJO037287; Sun, 1 Feb 2009 11:00:17 GMT (envelope-from gnats) Resent-Date: Sun, 1 Feb 2009 11:00:17 GMT Resent-Message-Id: <200902011100.n11B0HJO037287@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Luiz Otavio O Souza Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 211BA106566B for ; Sun, 1 Feb 2009 10:59:22 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 0F0B88FC0C for ; Sun, 1 Feb 2009 10:59:22 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n11AxLQi045950 for ; Sun, 1 Feb 2009 10:59:21 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n11AxLdP045949; Sun, 1 Feb 2009 10:59:21 GMT (envelope-from nobody) Message-Id: <200902011059.n11AxLdP045949@www.freebsd.org> Date: Sun, 1 Feb 2009 10:59:21 GMT From: Luiz Otavio O Souza To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/131250: [patch] ppp(8) proxyarp does not work X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2009 11:00:18 -0000 >Number: 131250 >Category: bin >Synopsis: [patch] ppp(8) proxyarp does not work >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Feb 01 11:00:17 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Luiz Otavio O Souza >Release: 7-STABLE >Organization: >Environment: FreeBSD fw.ad.com.br 7.1-STABLE FreeBSD 7.1-STABLE #7: Wed Jan 14 16:33:00 BRST 2009 root@fw.ad.com.br:/usr/obj/usr/src/sys/FW i386 >Description: If you are running the ppp as server (pppoe, pptp and others) the enable proxy option simply doesnt work. There is a case in the code where ncp_IfaceAddrAdded is not called and the proxyarp set routine never run. This patch fix this. >How-To-Repeat: Setup any ppp server with enable proxy on ppp.conf and try it. >Fix: Apply the patch. Patch attached with submission follows: --- iface.c.orig 2009-01-31 18:29:21.000000000 -0200 +++ iface.c 2009-01-31 18:28:17.000000000 -0200 @@ -456,6 +456,7 @@ if (ncprange_equal(&iface->addr[n].ifa, ifa) && ncpaddr_equal(&iface->addr[n].peer, peer)) { close(s); + ncp_IfaceAddrAdded(ncp, iface->addr + n); return 1; /* Already there */ } >Release-Note: >Audit-Trail: >Unformatted: