From nobody Sat Mar 19 23:18:03 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2CE8E1A36F67 for ; Sat, 19 Mar 2022 23:18:17 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KLcHq5ybKz4gmH for ; Sat, 19 Mar 2022 23:18:15 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647731888; bh=iQq8yBjmATnRUfdnfVXn7Za5vkkRXqrsGmpbSPhrAOk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=j6HZ51tJzbKtk2y+KXX1h1OnAVmlr7/yznxy6gbkmVJy0UmSJFx2jIt6hrnM1jjpC+N06l+iquujEi4BLY3Ur28xVkqbkIgdwx9605CPJ3iiyp9owER4Ki3X2nbkj98haB0gMoE9J1L3fdqS230cLG6CWeAd08huD7KQ6E7iUURVRzFVGks9Jz5GZqg7qpH+nGSGAqUitpyu3JkPba1Uvi1+SqBjuEWLkJ2LdjbqF9OWgPdaHS0kctk+m0sXNfqU+2CJgFeSrtmOdZpOgA6+Rv7TlJeT2W4W5lllvFmPvoUATZEohl14cZxmhphwsmsxKvnGCjnIEtjtVXVb54J+TQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647731888; bh=CAQfFTGj4aNyUxGCF1yKxSeQf5rb3zZ61WAgwlT73jj=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=VlimYS98FWXoXJXIvgYnzhd/LLg7jHy+deTdgjnt6ehJE58X86Jc1NQ/iOQx3zH4XOhP8yYuCzkVBlmeFoDyDlkSGAL4BskLWal3lPd2WLBrvJUbM5DO1Lo1M39bReExebbtMY5C/nZCgyMMYsO17knN1MMKF0vtSaqWdLKAWEwGavsX97QfW4EYHC3ZXDBdeNu7BzmKbtEbw24JTxAgK1y2qPB1N9bIB968A/lnockKgjcpTyjS/wsoF7265N6083vBbxgvM1JsEXTsibSAVCNNPuL9bC0t6+j4xzpT/XCt/xnYdCBH+miT8qTg176pfAc8xzW/6OS09BmuWpKKpA== X-YMail-OSG: i_..QqcVM1mwdFoPvDb75LKNKVrnrIh7wjSDXcxil4AnBWZww4TPrxnA_NTA90R TfpLQ.iCgI7XvCBaRl7ANdhq6oezpMmq3mLC._ycLZQ2VCQXgkl6sEzh7wwSo_2gnHXpb2UdaKQs UeFDyMkmADKKTs2DVsTBBuIFs4078SHc6l3AfKITl1bcpTRGiWVgRI8jwPX74QSVb8QBvQgih10J z5.Xdvu9SGpqC7Cx9Jw7ZHyr16nGHfMih5gQXqSy6VF4pT8tnklXkFC_PI3t_w8YYJxox2tTI88W p7IfwQJmcOF9G37aMtk8u0Sys4m_NGB5PydsvKM.7_0Ffy.AX0Pj2NhbGL5WTbFwMthD7edSyHLz MKElbcejXqzOg5I_UkEKkk3z9Dy4mbV3aumT6.nnXnlZC5YLMUbrHDmK0fz4nfILXz6yQk7r2jzv VcR8ydjwMy4tcoAz8UmTTKoPMSC1YmbtiazZNtkFdxASXghBMdWAqPCl_KSoBbGwwnhJ3129Bqp0 8vaQUtnIjMTi32rJDo9lAunFtXuHKNryOI61xFdsYg8NQdV0gBHlFvRI1_oDHvFomAqVGLBz9r4u DsSYExjHTMKC6XpogFshLom8bJsLMnX.ALXlmhliKFdXYTrcV8pQ5ZS9dCxZSK_1id8_ZvIo1RZZ 7KEmqC1T4TLaGY3v.efQjaMjVMSN0p.HEXYVE.x5K1KBL61L7dFvbAI9FRs5FU2Kp0tVTAZyVsm7 sK69iLcu9iXiAXQCuYQhrArON3C4KcAhDLp0JsF5Psq1vcYkbltf4FgzBz6eW7DeI_97_X8LxgVD 4PezNx4MZPKi.mn0t9nDNVgMu.KFYufxowu1hBfqrUJKEjcIlsWy1_Gc5YRtpZtBBH5Wzvgnve7H 76tVWjsDkFia5CepNXPpiEzwrRthoYbbgoIZTm_9XBFTYjBq.dDYcFXcOePwNF6waidKsiwcV13Z ehYws41VxoYXSPFmaWYE4B7.DMKU6hxNZCdYUKSTeOM8nvCRN_s5tsoYd3RddmYhvyHIoaIANXNJ UgL3ffCIc8PfNw9TqHy_J1cvy3yPq9vlw9Ybyckf918ppsncfP1hR2qUeCOPg8kr3Cil_ZMysr7Y .8zhd17sv_ViRx8kwqGrqocXIVgZfwBon1jBcF0aoxP2mWzXMXuDvLdo5tcFRuNXKKM6AdARK9uj LvDo6gqmzwClz015hOyKirMF2T8vJtzFXin_7WKjhuFHqgfa9tPgKyxC8P1Q1nBz5O9W_zygjyNB UKJnOCmP8ebHUPVlNJQYB876_itpf076qIQoGq11MfcBbDF7eQAdd1Mf1XneCrxQr0CdIDz3k6O5 qyEeXlIU_rhG3DaIYLLLODd3UvFTYp00BaoNKw_tlkNUUwwPKhckRboGWH0qRbVfrOYJNr.8Q2cq rXecYtU0LPQ9f2IMjjvb7uBkWMXYiCdfMktU3xjjQUDj9i8ea_qemq4kbN6i1n_u0Kqr5WdAI4Cy 2jT1P4UDtvNPxMR0Gy3UWIQKyMrTIDNOlXRkcWIkjVZPLAXdvFU03fd04HkHqj2om5FJRjTUGp9Z ucWOUbt5cP8ez0cDOUMxZdAvStXExqattpKlOySanDYLkHSMsLuYkeU_W.gcOFXRNvuj3t7htCpy gVkR6qMymsWUo6iqvsdEb2E99HGfx8mPrTTvG_4i.FsHOkJjE5Z.lvvIkPi5FxQhyoBRuJ45r36R vAZXEKgr369N7tsHcIWH8ibN806YOgOzE1ugwbkKccH5HrYFzrHYM2Z2soIgcMOfzg1hDLAsk5M2 lXshtTYXpfMbWZrsvi2IaskK_XajFPdxXPt9umZAn4f.D0Q6qldl0HvLSS9G.7hfUVHG6M6svelO _fPeWAyiovdoBXB7rHLsGQHkEoZI2wyAoX_qHjheWcAKbEeu7gQehhVj7gO7ivUfm1U0Cd0frbjT om8iYANyklySg7Qbh9svsxcDxDUkMxS_ci9ZtrvgZdaX8toXLDY7Q6.JY7RSfL9K4cMlcVdpXaTl 7tB.wVBlsq2IT4mvRrY7gHFyfB7jX4mXQMblViLG10kgMS00KZtpAOxoQznik3_3TwaTHBGSBzMr 2yxfz.xMbM9g97zM4pjI6uJqKhODBVQNi9U6mYxDRqkVhVLstoIgPsHAC4v_yZWIkvfY1d3mqJKD KtLBKBwSfQx2dBabv5_DQCMlFcKcv9JzkiWwYoAtW6651jBbvfsYAGCKxjl1ZPdwRzcMS9E6O6I. nfil297A.qR2YCELBGWTv53WRyG98WVPiccISBLNrAwANIF4bz3ZXHxmyObvs4f0Wv9mVUNhwGUG X_6JDrtEy1OX0LLdKjVUsSPsE0Gs- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Sat, 19 Mar 2022 23:18:08 +0000 Received: by hermes--canary-production-bf1-665cdb9985-l8dtt (VZM Hermes SMTP Server) with ESMTPA ID 789541486e6331b35abefc2b6a08688c; Sat, 19 Mar 2022 23:18:06 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: 43741377b143 - main - security/openssl: Security update to 1.1.1n From: Mark Millard In-Reply-To: Date: Sat, 19 Mar 2022 16:18:03 -0700 Cc: Thomas Zander , freebsd-ports@freebsd.org, FreeBSD-STABLE Mailing List , dev-commits-ports-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <46C5E80C-3038-4AF4-9E37-103586E3A318@yahoo.com> References: <2E632408-4D4E-426C-8DC7-A1024A1D328D.ref@yahoo.com> <2E632408-4D4E-426C-8DC7-A1024A1D328D@yahoo.com> <4370EEAF-A332-4DEB-8E21-B24689857463@yahoo.com> To: Mark Johnston X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4KLcHq5ybKz4gmH X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=j6HZ51tJ; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.65.147 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-1.57 / 15.00]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; RCPT_COUNT_FIVE(0.00)[5]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_MEDIUM(0.93)[0.929]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.147:from]; MLMMJ_DEST(0.00)[freebsd-stable]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.147:from]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On 2022-Mar-19, at 14:34, Mark Millard wrote: > On 2022-Mar-19, at 14:24, Mark Millard wrote: >=20 >> On 2022-Mar-19, at 12:54, Mark Johnston wrote: >>=20 >>> On Sat, Mar 19, 2022 at 12:00:20PM -0700, Mark Millard wrote: >>>> On 2022-Mar-19, at 11:07, Thomas Zander wrote: >>>>=20 >>>>> On Sat, 19 Mar 2022 at 18:32, Mark Millard = wrote: >>>>>> May be report to Mark J. how to run the same test builds >>>>>> that failed for -p8 but worked for -p7? >>>>>=20 >>>>> Sure, good point. >>>>> A build that reliably causes broken packages on p8 but not on p7 = for >>>>> me is running: >>>>>=20 >>>>> poudriere testport -o multimedia/mplayer -j <13.0-amd64-jail here> >>>>>=20 >>>>> This caused the broken png and python packages when they were = built as >>>>> dependencies. >>>>> In poudriere.conf I set this: >>>>> DISTFILES_CACHE=3D/vcache/distfiles >>>>> CCACHE_DIR=3D/vcache/ccache >>>>> ALLOW_MAKE_JOBS=3Dyes >>>>>=20 >>>>> The ALLOW_MAKE_JOBS should increase the number of parallel IO >>>>> operations in-flight on the pool, maybe this increases the = likelihood >>>>> of triggering the issue? >>>>> The DISTFILES_CACHE and CCACHE_DIR are in the same zfs pool as >>>>> /poudriere, not sure if this is relevant. >>>>> The zfs pool is a single disk, no raid, mirror or anything fancy. >>>>=20 >>>> On a ThreadRipper 1950X, PCIe Optane storage, 128 GiBytes of >>>> RAM, I've used bectl to boot the 13.0_RELEASE-p8 environment >>>> and have started: >>>>=20 >>>> poudriere testport -o multimedia/mplayer -j13_0R-amd64-bulk_a >>>>=20 >>>> where the jail had nothing built in it at the start. So: >>>>=20 >>>> [00:00:08] Building 271 packages using up to 32 builders >>>>=20 >>>> The primary difference is that I've never used ccache and >>>> did not try to do so here. The "zfs pool is a single disk, >>>> no raid, mirror or anything fancy" is accurate, as is the >>>> use of ALLOW_MAKE_JOBS=3D . >>>>=20 >>>> That did not take long . . . >>>>=20 >>>> It proves that ccache is not required. Also some files >>>> seem to get only small blocks of zero-bytes, others >>>> large ones. But I've not checked for the null characters >>>> being at the end instead of earlier in the file. >>>=20 >>> I still am not able to reproduce it. I think it's indeed a = concurrency >>> problem, and I found a possible culprit. Mark or Thomas, if you're = able >>> to build a new kernel from the releng/13.0 branch and test it, could = you >>> please try this patch? >>>=20 >>=20 >> Sure. (I build ports in a way that allows large load >> averages relative to the hardware-thread count. I also >> have a lot of swap configured. I avoid significant use >> of tmpfs.) >>=20 >>> diff --git a/sys/contrib/openzfs/module/zfs/dnode.c = b/sys/contrib/openzfs/module/zfs/dnode.c >>> index 8592c5f8c3a9..b69ba68ec780 100644 >>> --- a/sys/contrib/openzfs/module/zfs/dnode.c >>> +++ b/sys/contrib/openzfs/module/zfs/dnode.c >>> @@ -1661,7 +1661,7 @@ dnode_is_dirty(dnode_t *dn) >>> mutex_enter(&dn->dn_mtx); >>>=20 >>> for (int i =3D 0; i < TXG_SIZE; i++) { >>> - if (list_head(&dn->dn_dirty_records[i]) !=3D NULL) { >>> + if (multilist_link_active(&dn->dn_dirty_link[i])) { >>> mutex_exit(&dn->dn_mtx); >>> return (B_TRUE); >>> } >>>=20 >>=20 >> Change made. >> Rebuilt. >> Reinstalled. >> Rebooted into the 13_0R-amd64 be area. >> Bulk build started. >> Bulk build completed. >> (Took longer because I let it run to completion.) >>=20 >> No explicit reports of null characters. The same 2 ports that >> failed before, not reporting zero-byte issues, failed again. >> Likely independent issues: >>=20 >> [00:28:28] Failed ports: security/libgcrypt:build = print/freetype2:package >=20 > These are what happens for WITH_DEBUG=3D style builds. Turns > out that the *make.conf files from my last bulk -a experiment > were still in place and were causing WITH_DEBUG=3D builds. (Not > my normal context.) >=20 > I'll disable that and rerun the bulk from scratch. Done. No failures. >> Overall it skipped something like 54 ports. >>=20 >> libgcrypt-1.9.4.log . . . >>=20 >> --- basic.o --- >> basic.c:315:16: error: inline assembly requires more registers than = available >> asm volatile("movdqu %[data0], %%xmm0\n" >> ^ >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> --- mpitests --- >> . . . >> --- basic.o --- >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> basic.c:315:16: error: inline assembly requires more registers than = available >> fatal error: too many errors emitted, stopping now [-ferror-limit=3D] >>=20 >>=20 >> freetype2-2.11.1.log . . . >>=20 >> =3D=3D=3D> Building package for freetype2-2.11.1 >> pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= :No such file or directory >> pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= .6:No such file or directory >> pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= .6.18.1:No such file or directory >> *** Error code 1 >>=20 >>=20 >> I think this indicates that your fix works. >>=20 >>=20 >>=20 >> For reference: >>=20 >> # ~/fbsd-based-on-what-commit.sh -C /usr/ports/ >> branch: main >> merge-base: 0c4fe38bd1b9e3ede128751db17a8a2d1bdffe6f >> merge-base: CommitDate: 2022-03-15 16:15:33 +0000 >> 0c4fe38bd1b9 (HEAD -> main, freebsd/main, freebsd/HEAD) misc/urh: = Update 2.9.2 -> 2.9.3 >> n577366 (--first-parent --count for merge-base) >=20 Avoiding WITH_DEBUG=3D use, everything built, no error logs. SET PORTS JAIL BUILD STATUS = QUEUE BUILT FAIL SKIP IGNORE FETCH REMAIN TIME LOGS . . . - default 13_0R-amd64-bulk_a 2022-03-19_14h35m20s done = 272 272 0 0 0 0 0 01:33:16 = /usr/local/poudriere/data/logs/bulk/13_0R-amd64-bulk_a-default/2022-03-19_= 14h35m20s . . . SIDE NOTE for multimedia/mplayer : =3D=3D=3D=3D> Running Q/A tests (stage-qa) Error: /usr/local/bin/mplayer is linked to /usr/local/lib/libjpeg.so.8 = from graphics/jpeg-turbo but it is not declared as a dependency Warning: you need USES+=3Djpeg Error: /usr/local/bin/mplayer is linked to = /usr/local/lib/libdvdread.so.8 from multimedia/libdvdread but it is not = declared as a dependency Warning: you need LIB_DEPENDS+=3Dlibdvdread.so:multimedia/libdvdread Error: /usr/local/bin/mplayer is linked to /usr/local/lib/libcairo.so.2 = from graphics/cairo but it is not declared as a dependency Warning: you need USE_GNOME+=3Dcairo Error: /usr/local/bin/mplayer is linked to = /usr/local/lib/libgdk_pixbuf-2.0.so.0 from graphics/gdk-pixbuf2 but it = is not declared as a dependency Warning: you need USE_GNOME+=3Dgdkpixbuf2 Error: /usr/local/bin/mplayer is linked to = /usr/local/lib/libharfbuzz.so.0 from print/harfbuzz but it is not = declared as a dependency Warning: you need LIB_DEPENDS+=3Dlibharfbuzz.so:print/harfbuzz Warning: Possible REINPLACE_CMD issues: - - REINPLACE_CMD ran, but did not modify file contents: = debian/daily-build.sh - - REINPLACE_CMD ran, but did not modify file contents: version.sh - - REINPLACE_CMD ran, but did not modify file contents: = DOCS/tech/release.sh - - REINPLACE_CMD ran, but did not modify file contents: = tests/faterun.sh - - REINPLACE_CMD ran, but did not modify file contents: = tests/refupdate.sh - - REINPLACE_CMD ran, but did not modify file contents: = help/help_create.sh - - REINPLACE_CMD ran, but did not modify file contents: = help/help_check.sh - - REINPLACE_CMD ran, but did not modify file contents: = vidix/dhahelperwin/NMAKEFILE - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/subsearch.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/checktree.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/divx2svcd.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/mencvcd.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/coverity.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/qepdvcd.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/mpconsole.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/midentify.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/binary_codecs.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/psnr-video.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/aconvert.sh - - REINPLACE_CMD ran, but did not modify file contents: = TOOLS/mplmult.sh =3D=3D=3D Mark Millard marklmi at yahoo.com