From owner-svn-src-all@FreeBSD.ORG Sat Mar 17 23:53:43 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DC53B106566B; Sat, 17 Mar 2012 23:53:43 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay020.isp.belgacom.be (mailrelay020.isp.belgacom.be [195.238.6.95]) by mx1.freebsd.org (Postfix) with ESMTP id DA9BA8FC08; Sat, 17 Mar 2012 23:53:42 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlcFAEQjZU9bsV9U/2dsb2JhbABCsziDCIEIggkBAQQBViMFCwsOCi45HgaIGAm5NJB8BIgjihMCApNWgmc Received: from 84.95-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.95.84]) by relay.skynet.be with ESMTP; 18 Mar 2012 00:52:33 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.5/8.14.5) with ESMTP id q2HNqVDg004754; Sun, 18 Mar 2012 00:52:32 +0100 (CET) (envelope-from tijl@freebsd.org) From: Tijl Coosemans To: Bruce Evans Date: Sun, 18 Mar 2012 00:52:23 +0100 User-Agent: KMail/1.13.7 (FreeBSD/10.0-CURRENT; KDE/4.7.3; i386; ; ) References: <201203161942.q2GJgdPU032060@svn.freebsd.org> <4F642A1A.4070006@freebsd.org> <20120317223612.D2494@besplex.bde.org> In-Reply-To: <20120317223612.D2494@besplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart12110572.yYjvuLxiXs"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit Message-Id: <201203180052.29167.tijl@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Julian Elischer Subject: Re: svn commit: r233043 - head/sys/i386/include X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2012 23:53:44 -0000 --nextPart12110572.yYjvuLxiXs Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Saturday 17 March 2012 12:48:17 Bruce Evans wrote: > On Fri, 16 Mar 2012, Julian Elischer wrote: >> On 3/16/12 12:42 PM, Tijl Coosemans wrote: >>> int32_t en_sw; /* status word (16bits) */ >> >> what's wrong with this picture? >=20 > Only the excessive indentation in the new version. There's only one tab in the uint16_t fields and style(9) says two tabs for the other fields is ok unless it affects at least 90% of the fields which isn't the case here. > The 16 in the comment is not mismatched with 32 in the code, but is > less needed that before, since it is more obvious that the code uses > 32 and it goes without saying that this would only be used if it is > correct. The comment says that although field has 32 bits in memory, > only 16 bits of it are used in the status word register. For fields > in this struct that use all of the bits in memory, no comment is made > about the number of bits in the register, and vice versa. I forget > if the padding bits in memory are read or written by the hardware. On > write, they might not be touched, or they might be filled with garbage, > or all zeros, or all 1's, or a "reserved" not-quite garbage value. > Probably closest the latter, with the actual bits being all 0 or all > 1. On read, they might be ignored or checked for garbage. I think > they are ignored for this file.d AMD documentation says the upper 16 bits are "reserved,ignored" which means their value is indeterminate, but the cpu doesn't care about them. --nextPart12110572.yYjvuLxiXs Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EABEIAAYFAk9lI7wACgkQfoCS2CCgtiuWtwD/dgrxDW/F7ESV3TybI1rpQjc4 RNqV8+0cgOke2BQRxccA/3XUIZHY7AiWTMk3c/lT2QMsj4PgKcdDP31WDNF6g7DZ =sc3k -----END PGP SIGNATURE----- --nextPart12110572.yYjvuLxiXs--