From owner-freebsd-gnome@FreeBSD.ORG  Sat Jun 28 18:20:26 2008
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 95C2F10656B8;
	Sat, 28 Jun 2008 18:20:26 +0000 (UTC)
	(envelope-from marcus@marcuscom.com)
Received: from creme-brulee.marcuscom.com (unknown
	[IPv6:2001:470:1f00:ffff::1279])
	by mx1.freebsd.org (Postfix) with ESMTP id 24F6F8FC18;
	Sat, 28 Jun 2008 18:20:25 +0000 (UTC)
	(envelope-from marcus@marcuscom.com)
Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com
	[IPv6:2001:470:1f00:2464::4])
	by creme-brulee.marcuscom.com (8.14.2/8.14.2) with ESMTP id
	m5SIL1wW084997; Sat, 28 Jun 2008 14:21:02 -0400 (EDT)
	(envelope-from marcus@marcuscom.com)
From: Joe Marcus Clarke <marcus@marcuscom.com>
To: Jens Rehsack <rehsack@web.de>
In-Reply-To: <485E6E98.9000106@web.de>
References: <485E6E98.9000106@web.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-eNBZcMKnL2WBlLrtBHt4"
Organization: MarcusCom, Inc.
Date: Sat, 28 Jun 2008 14:20:36 -0400
Message-Id: <1214677236.86194.7.camel@shumai.marcuscom.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.2 FreeBSD GNOME Team Port 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS
	autolearn=ham version=3.2.4
X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on
	creme-brulee.marcuscom.com
Cc: FreeBSD GNOME Users <gnome@freebsd.org>, delphij@freebsd.org,
	bug-followup@freebsd.org
Subject: Re: ports/124115: net/openldap24-server: Auto-Detect OpenLDAP
	version and modify knobs according to common names
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Jun 2008 18:20:26 -0000


--=-eNBZcMKnL2WBlLrtBHt4
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, 2008-06-22 at 15:24 +0000, Jens Rehsack wrote:
> Hi,
>=20
> I tried a little around with the submitted patch and detected 2 issues:
> 1) I had a typo in line 37 of bsd.ldap.mk
> -DEFAULT_OPENLDPAP_VER?=3D 23
> +DEFAULT_OPENLDAP_VER?=3D 23
> It's quite easy to fix it ;)
>=20
> 2) A port (security/seahorse) checks in line 72 for ${WANT_OPENLDAP_VER},
>     which is deprecated. By the way - it doesn't want to check for
>     WANT_OPENLDAP_VER, it wants to check for ${OPENLDAP_VER}.
>     Doing this would require to split the "code" in bsd.ldap.mk into a
>     pre- and post-part, not handle everything in the post-part.
>=20
> What do you think?

I've been away for a week and a half.  Has anything come of this?  I
have no objection to making seahorse more flexible in terms of LDAP
support if the underlying code supports it.

Joe

--=20
PGP Key : http://www.marcuscom.com/pgp.asc

--=-eNBZcMKnL2WBlLrtBHt4
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEABECAAYFAkhmgPMACgkQb2iPiv4Uz4dxoACfUprJiRxufdIimM0oXbBAEMP8
Pf0AoICNfO9l86hp69Fy74KfY+MWy6Zv
=2tD6
-----END PGP SIGNATURE-----

--=-eNBZcMKnL2WBlLrtBHt4--