From nobody Thu Aug 6 01:42:05 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFqlR1bZdz6nZ33 for ; Thu, 06 Aug 2026 01:42:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFqlR0Gzzz3Tgy for ; Thu, 06 Aug 2026 01:42:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785980531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FeGFH4N6/0MiRVJfDmDBHk8D98rSnLo3ntp1oCJOhBE=; b=m/yajSfggEHi/Uf/xasqEhjQ6AxB4OVbflousnxKvR/PKeDn0fHHw+U2KP+f+GOCrS59+5 xYJnGDVbmjKJoiI6p6zcytquw2Yj7227BaSh8ggbhaJmCrncDJi/h6AbI6WKCBoSrenpFl B+eIMzjr8aRjjqr4PHLCHR2ZuwGx1VKYgxKY+YCv5Iqv/eytdRTt3LDBQQOS5lZZjSF8mZ XnJNtv2Dxw4m64qC3xIWgjH8Pp7CoSIqKSRnIdPzxyLg/oVfdXaO/D2Wl7XlBYd/xtidSi ECmj8hEtEKowRHJ66455iMK7NP36pnJHOhQEzclXuwnw3iBy7oy4NbSeiXtnoQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785980531; a=rsa-sha256; cv=none; b=wv0QrjTk4ARMs2QlxMKJ3nP92ZvwuQ2DuuRTT6A1FPP96FY7sm7zsIqEfQUwXLOReesfKZ PuUN4RKVBp3jJb+Koh0D3csLGwHXHbJeynkDE/Qxxa8Pt3hIoBtzPEqK+igvzzGWmYxJ7a UyvjDi9Gzl+ZCQY//RRab2E5AmcPdKHIq31tS8QjNBuuR1S62Egcf4qfOwrqznMN6ypzN5 +Nnfi4icyts7m7psiaa+Q3ZZZy2FzSJaq2R7J4A6dft2ORI1/u9ks/GtTJpqnOmM47No/h dX1W+hgF+ZsDbBbpcDlcQELNRgmk8smcmrLRv7XN0rN1klUh15hGckzojOsHjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785980531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FeGFH4N6/0MiRVJfDmDBHk8D98rSnLo3ntp1oCJOhBE=; b=U7f9OmJEvtocBX81+0tSLP5/Q7bd4V4gIX47ShFsfSvOuGCAJ4cQs7L6V9IXZbEa8BFUuf uc43xDMPPHz+48Neqhw2h4sszflXOR7fxkThFaqqBkcz2JPPu3gKjs2PJCC6TXlyv/7sY9 S24QaAzrNll51I39isB+kcndGhPId65ls3crgRdh0XfF4GtFsrKNnJpHloCMbHOJhTjF11 RWrt4i6DI4x3/brg2edOliE9KRof/LrtbemdQkV306YALYxJzgCO0F/yOgCbJLYdjDLw9v TN9YpqaM85Rc6xthbcxGXYx8+7XCgk19X2jz2jUGttYghkG5xTyTMMAf6T7kKA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFqlQ6Mvbz108H for ; Thu, 06 Aug 2026 01:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3a794 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 06 Aug 2026 01:42:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Li-Wen Hsu Subject: git: e6b49d71f259 - stable/15 - libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: lwhsu X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: e6b49d71f25932b043575535cbe35c917bd71768 Auto-Submitted: auto-generated Date: Thu, 06 Aug 2026 01:42:05 +0000 Message-Id: <6a73e66d.3a794.9634f37@gitrepo.freebsd.org> The branch stable/15 has been updated by lwhsu: URL: https://cgit.FreeBSD.org/src/commit/?id=e6b49d71f25932b043575535cbe35c917bd71768 commit e6b49d71f25932b043575535cbe35c917bd71768 Author: Li-Wen Hsu AuthorDate: 2026-06-27 02:26:05 +0000 Commit: Li-Wen Hsu CommitDate: 2026-08-06 01:40:09 +0000 libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode dt_print_sym() fills the symbol string via snprintf() in non-oformat mode but the guarding `dtp->dt_oformat != 0 &&` for the dt_printf() call causes the symbol is computed but never emitted. This fixes tests: - common.profile-n.t_dtrace_contrib.tst_sym_ksh - common.profile-n.t_dtrace_contrib.tst_func_ksh Reviewed by: markj Fixes: 93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option") MFC after: 3 days Event: Halifax Hackathon 202606 Location: Room 208, Computer Science Building, Dalhousie University Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57895 (cherry picked from commit 8e61d8707f8a10acc143210089fea2502a3f2922) --- cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c index b311b5425587..a8a49b22ed7b 100644 --- a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c +++ b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c @@ -2143,7 +2143,7 @@ dt_print_sym(dtrace_hdl_t *dtp, FILE *fp, const char *format, caddr_t addr) } } - if (dtp->dt_oformat != 0 && dt_printf(dtp, fp, format, c) < 0) + if (!dtp->dt_oformat && dt_printf(dtp, fp, format, c) < 0) return (-1); return (0);