From owner-freebsd-current Mon Jan 27 0:11:34 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13D4F37B401 for ; Mon, 27 Jan 2003 00:11:33 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80BCF43E4A for ; Mon, 27 Jan 2003 00:11:32 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.6/8.12.2) with ESMTP id h0R8BVIx088608; Mon, 27 Jan 2003 00:11:31 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.6/8.12.6/Submit) id h0R8AFgd088595; Mon, 27 Jan 2003 00:10:15 -0800 (PST) Date: Mon, 27 Jan 2003 00:10:15 -0800 From: "David O'Brien" To: Maxim Konovalov Cc: current@freebsd.org Subject: Re: [PATCH]: newfs(8) FS_OPTSPACE vs FS_OPTTIME bug Message-ID: <20030127081015.GC61926@dragon.nuxi.com> Reply-To: obrien@freebsd.org Mail-Followup-To: David O'Brien , Maxim Konovalov , current@freebsd.org References: <20030123133044.G77851@news1.macomnet.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030123133044.G77851@news1.macomnet.ru> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Jan 23, 2003 at 01:42:58PM +0300, Maxim Konovalov wrote: > Any objections to a diff below? We should be moving away from magic numbers to #defined constants, not the otherway around. > Index: newfs/newfs.c > =================================================================== > RCS file: /home/ncvs/src/sbin/newfs/newfs.c,v > retrieving revision 1.66 > diff -u -r1.66 newfs.c > --- newfs/newfs.c 30 Nov 2002 18:28:26 -0000 1.66 > +++ newfs/newfs.c 23 Jan 2003 10:26:45 -0000 > - if (minfree < MINFREE && opt != FS_OPTSPACE) { > + if (minfree <= 5 && opt != FS_OPTSPACE) { > - fprintf(stderr, "because minfree is less than %d%%\n", MINFREE); > + fprintf(stderr, "because minfree is less than %d%%\n", 5); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message